Skip to content

Commit 2fe3411

Browse files
Simplify compile loop per code review feedback
Co-authored-by: AbhishekBhaskar <[email protected]>
1 parent fba51c0 commit 2fe3411

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

python/lib/dependabot/python/file_updater/pip_compile_file_updater.rb

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -109,16 +109,11 @@ def compile_new_requirement_files
109109

110110
filenames_to_compile.each do |filename|
111111
# Compile the file for each of its output files
112-
# A single .in file may generate multiple .txt files
112+
# A single .in file may generate multiple .txt files with different --output-file options
113113
output_files = compiled_files_for_filename(filename)
114-
if output_files.any?
115-
output_files.each do |output_file|
116-
compile_file(filename, output_file)
117-
end
118-
else
119-
# No known output file, use default compilation
120-
compile_file(filename, nil)
121-
end
114+
# When no output files are found, compile with nil to use default pip-compile behavior
115+
output_files = [nil] if output_files.empty?
116+
output_files.each { |output_file| compile_file(filename, output_file) }
122117
end
123118

124119
# Remove any .python-version file before parsing the reqs

0 commit comments

Comments
 (0)