Skip to content

Preserve issue_comment triggers in Depot CI migration - #602

Merged
PedroGuerraPT merged 1 commit into
mainfrom
codex/t12026-issue-comment-compat
Sep 28, 2026
Merged

PedroGuerraPT merged 1 commit into
mainfrom
codex/t12026-issue-comment-compat

Conversation

@PedroGuerraPT

@PedroGuerraPT PedroGuerraPT commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Change

  • Mark issue_comment as supported in CLI compatibility rules.
  • Preserve created, edited, and deleted activity filters when transforming workflows.
  • Add compatibility and transform regression cases.

Note

Low Risk
Compatibility metadata and test coverage only; migration behavior broadens to retain an additional trigger type with no auth or data-path changes.

Overview
Treats the GitHub Actions issue_comment trigger as supported for Depot CI migration instead of flagging it and stripping it during transform.

TriggerRules now marks issue_comment as Supported (with updated compatibility text and no removal suggestion). Workflows that run on issue/PR conversation comments should keep the trigger and types filters (e.g. created, edited, deleted) when migrated, rather than recording ChangeTriggerRemoved.

Regression tests cover compatibility analysis, the supported-trigger list, and transform output for an issue_comment workflow.

Reviewed by Cursor Bugbot for commit e6d3c77. Bugbot is set up for automated code reviews on this repo. Configure here.

@PedroGuerraPT
PedroGuerraPT marked this pull request as ready for review September 28, 2026 13:47

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: low. Approved based on passing Cursor Bugbot and Cursor Security Agent checks with no findings that need human review. No reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@PedroGuerraPT
PedroGuerraPT merged commit 3749405 into main Sep 28, 2026
12 checks passed
@PedroGuerraPT
PedroGuerraPT deleted the codex/t12026-issue-comment-compat branch September 28, 2026 13:58
@linear-code

linear-code Bot commented Sep 28, 2026

Copy link
Copy Markdown

DEP-6961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant