Skip to content

commit sha logging #2505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
motatoes merged 1 commit into from
Dec 6, 2025
Merged

commit sha logging #2505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Dockerfile_ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,14 @@ RUN --mount=type=cache,target=/root/.npm \
########### Runtime: minimal production image ###########
FROM node:22-alpine AS runner

ARG COMMIT_SHA
WORKDIR /app

# Set env before install so some libs can optimize for production
ENV NODE_ENV=production
ENV PORT=3030
ENV HOST=0.0.0.0
ENV COMMIT_SHA=${COMMIT_SHA}

# Install only production deps
COPY ui/package.json ui/package-lock.json ./
Expand Down
3 changes: 2 additions & 1 deletion ui/request-logging.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,15 @@ export function logRequestInit(method, path, requestId, userId, orgId) {
}));
}

export function logResponse(method, path, requestId, latency, statusCode) {
export function logResponse(method, path, requestId, latency, statusCode, commitSha) {
console.log(JSON.stringify({
event: 'response_sent',
method,
path,
requestId,
latency,
statusCode,
commitSha: commitSha || 'unknown',
}));
}

13 changes: 7 additions & 6 deletions ui/server-start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const __dirname = fileURLToPath(new URL('.', import.meta.url));
const PORT = process.env.PORT || 3030;
const HOST = process.env.HOST || '0.0.0.0';
const REQUEST_TIMEOUT = 60 * 1000; // 60s timeout for requests
const COMMIT_SHA = process.env.COMMIT_SHA || 'unknown';

// Configure global fetch with connection pooling for much better performance
// Without this, every fetch creates a new TCP connection (DNS + handshake overhead)
Expand Down Expand Up @@ -110,7 +111,7 @@ const server = createServer(async (req, res) => {

// Set request timeout
req.setTimeout(REQUEST_TIMEOUT, () => {
console.error(`⏱️ Request timeout (${REQUEST_TIMEOUT}ms): ${req.method} ${req.url} [${requestId}]`);
console.error(`⏱️ Request timeout (${REQUEST_TIMEOUT}ms): ${req.method} ${req.url} [${requestId}] [commitSha: ${COMMIT_SHA}]`);
if (!res.headersSent) {
res.writeHead(408, { 'Content-Type': 'text/plain' });
res.end('Request Timeout');
Expand Down Expand Up @@ -140,7 +141,7 @@ const server = createServer(async (req, res) => {
// Log response for static files
try {
const latency = Date.now() - requestStart;
logResponse(method, pathname, requestId, latency, 200);
logResponse(method, pathname, requestId, latency, 200, COMMIT_SHA);
} catch (err) {
console.error(`Response logging error [${requestId}]:`, err);
}
Expand Down Expand Up @@ -177,9 +178,9 @@ const server = createServer(async (req, res) => {

// Log slow SSR requests
if (ssrTime > 2000) {
console.debug(`🔥 VERY SLOW SSR: ${req.method} ${pathname} took ${ssrTime}ms [${requestId}]`);
console.debug(`🔥 VERY SLOW SSR: ${req.method} ${pathname} took ${ssrTime}ms [${requestId}] [commitSha: ${COMMIT_SHA}]`);
} else if (ssrTime > 1000) {
console.debug(`⚠️ SLOW SSR: ${req.method} ${pathname} took ${ssrTime}ms [${requestId}]`);
console.debug(`⚠️ SLOW SSR: ${req.method} ${pathname} took ${ssrTime}ms [${requestId}] [commitSha: ${COMMIT_SHA}]`);
}

// Convert Web Standard Response to Node.js response
Expand Down Expand Up @@ -270,7 +271,7 @@ const server = createServer(async (req, res) => {
// Log response after sending
try {
const latency = Date.now() - requestStart;
logResponse(method, pathname, requestId, latency, res.statusCode);
logResponse(method, pathname, requestId, latency, res.statusCode, COMMIT_SHA);
} catch (err) {
console.error(`Response logging error [${requestId}]:`, err);
}
Expand All @@ -284,7 +285,7 @@ const server = createServer(async (req, res) => {
// Log error response
try {
const latency = Date.now() - requestStart;
logResponse(method, pathname, requestId, latency, res.statusCode || 500);
logResponse(method, pathname, requestId, latency, res.statusCode || 500, COMMIT_SHA);
} catch (err) {
console.error(`Error response logging error [${requestId}]:`, err);
}
Expand Down
Loading