Skip to content

Issue 34:- Handle events without coordinates to avoid placing them at… #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kehach07 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Open

Issue 34:- Handle events without coordinates to avoid placing them at… #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions assets/js/events_map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,16 @@ function getColorByCategory(category) {
let singleEventPopupLayer = null;

function renderEvents(geojsonData, singleEventGeojsonData) {
// FIX: Remove events with missing/null coordinates
geojsonData.features = geojsonData.features.filter(f => {
return (
f.geometry &&
f.geometry.coordinates &&
f.geometry.coordinates.length === 2 &&
f.geometry.coordinates[0] !== null &&
f.geometry.coordinates[1] !== null
);
});
if (!geojsonData) {
return
}
Expand Down Expand Up @@ -82,6 +92,9 @@ function renderEvents(geojsonData, singleEventGeojsonData) {

const geojsonLayer = L.geoJSON(geojsonData, {
pointToLayer: (feature, latlng) => {
if (!feature.geometry || !feature.geometry.coordinates || feature.geometry.coordinates.includes(null)) {
return; // skip this feature entirely
}
const category = feature.properties.event_category;
const color = getColorByCategory(category);
const marker = L.circleMarker(latlng, {
Expand Down