feat(pkg/history): redact secrets in command history#2892
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
aheritier
added
area/security
dgageot
force-pushed
the
board/a770644694719aa4
branch
from
4db1879 to
e7d2667
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
dgageot
force-pushed
the
board/a770644694719aa4
branch
from
e7d2667 to
1e36dc6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
rumpl
previously approved these changes
May 26, 2026
…history entries through portcullis.Redact before storing them Signed-off-by: David Gageot <david.gageot@docker.com>
dgageot
force-pushed
the
board/a770644694719aa4
branch
from
1e36dc6 to
b3b91ae
Compare
rumpl
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command history should never contain secrets. This change routes all history entries through
portcullis.Redactbefore storing them, ensuring that API tokens and other credentials pasted at the prompt never reach the in-memory slice or the~/.cagent/historyfile.The history package now redacts entries when adding them and when migrating from the legacy history file. A critical fix ensures that pre-existing secrets in the old
~/.cagent/history.jsonformat are redacted on migration, closing a gap where secrets could be copied verbatim into the new format on first launch.The remaining commits consolidate test setup code and clean up redundant parsing logic, improving maintainability with no behavioral change.