Merge pull request #218 from docker/slim/dynamictools1

Enable Dynamic Tools by Default and Enhance MCP Management

Author: slimslenderslacks

cmd/docker-mcp/commands/gateway.go

@@ -320,12 +320,12 @@ func isMcpOAuthDcrFeatureEnabled(dockerCli command.Cli) bool {
 func isDynamicToolsFeatureEnabled(dockerCli command.Cli) bool {
 	configFile := dockerCli.ConfigFile()
 	if configFile == nil || configFile.Features == nil {
-		return false // Default disabled when no config exists
+		return true // Default enabled when no config exists
 	}
 
 	value, exists := configFile.Features["dynamic-tools"]
 	if !exists {
-		return false // Default disabled when not in config
+		return true // Default enabled when not in config
 	}
 
 	return value == "enabled"

cmd/docker-mcp/commands/gateway_test.go

@@ -88,31 +88,31 @@ func TestIsDynamicToolsFeatureEnabled(t *testing.T) {
 			Features: map[string]string{},
 		}
 		enabled := isDynamicToolsFeatureEnabledFromConfig(configFile)
-		assert.False(t, enabled, "should return false when dynamic-tools is not set")
+		assert.True(t, enabled, "should return true when dynamic-tools is not set (default enabled)")
 	})
 
 	t.Run("nil config", func(t *testing.T) {
 		enabled := isDynamicToolsFeatureEnabledFromConfig(nil)
-		assert.False(t, enabled, "should return false when config is nil")
+		assert.True(t, enabled, "should return true when config is nil (default enabled)")
 	})
 
 	t.Run("nil features", func(t *testing.T) {
 		configFile := &configfile.ConfigFile{
 			Features: nil,
 		}
 		enabled := isDynamicToolsFeatureEnabledFromConfig(configFile)
-		assert.False(t, enabled, "should return false when features is nil")
+		assert.True(t, enabled, "should return true when features is nil (default enabled)")
 	})
 }
 
 // Helper function for testing (extract logic from isDynamicToolsFeatureEnabled)
 func isDynamicToolsFeatureEnabledFromConfig(configFile *configfile.ConfigFile) bool {
 	if configFile == nil || configFile.Features == nil {
-		return false // Default disabled when no config exists
+		return true // Default enabled when no config exists
 	}
 	value, exists := configFile.Features["dynamic-tools"]
 	if !exists {
-		return false // Default disabled when not in config
+		return true // Default enabled when not in config
 	}
 	return value == "enabled"
 }

examples/cagent/agent.yaml

@@ -1,9 +1,8 @@
 version: v2
-
 agents:
   root:
     model: claude
-    description: Root orchestrator agent that coordinates tasks and delegates to specialized sub-agents
+    description: An agent to help you discover MCPs from a local catalog
     instruction: |
       You are a specialized agent with access to MCP (Model Context Protocol) server tools
       running through the Docker MCP Gateway.
@@ -19,16 +18,12 @@ agents:
       3. Return clear, structured results to the parent agent
       4. Handle errors gracefully and suggest alternatives
     toolsets:
-      - type: filesystem # Grants the agent filesystem access
-      - type: todo # Enable the todo list tool
       - type: mcp
         command: docker
         args:
           - mcp
           - gateway
           - run
-          - --log=/Users/slim/gateway.log
-
 models:
   claude:
     provider: anthropic