use appropriate type for config attributes #268
Merged
+87
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did I noticed all of the config attributes were stored as plain strings. Instead of handling the parsing logic on the client side, I believe it's better to do it in the CLI. I've added JSON parsing when setting values and also displaying them in the correct type.
Related issue
Notice: booleans and numbers not being strings. Also the string array in the second example.
(not mandatory) A picture of a cute animal, if possible in relation to what you did