Skip to content

Conversation

@Daniel-Kolev
Copy link
Contributor

What I did I noticed all of the config attributes were stored as plain strings. Instead of handling the parsing logic on the client side, I believe it's better to do it in the CLI. I've added JSON parsing when setting values and also displaying them in the correct type.

Related issue

Notice: booleans and numbers not being strings. Also the string array in the second example.

docker mcp profile config redis --get-all --format=json
{
  "redis.cluster_mode": false,
  "redis.host": "localhost",
  "redis.port": 6379,
  "redis.ssl": false,
  "redis.ssl_keyfile": "f"
}
docker mcp profile config file --get-all --format=json
{
  "filesystem.paths": [
    "/Users/dk/dev",
    "/Users/dk/tmp"
  ]
}

(not mandatory) A picture of a cute animal, if possible in relation to what you did

image

@Daniel-Kolev Daniel-Kolev requested a review from a team as a code owner November 27, 2025 14:26
Copy link
Contributor

@cmrigney cmrigney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@Daniel-Kolev Daniel-Kolev merged commit c4ca6b3 into main Dec 2, 2025
8 checks passed
@Daniel-Kolev Daniel-Kolev deleted the type-mcp-profile-server-configuration branch December 2, 2025 15:16
null-runner pushed a commit to null-runner/mcp-gateway that referenced this pull request Dec 6, 2025
…figuration

use appropriate type for config attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants