SignHost: Fall back to ECDSA when CA key type cannot be imitated #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsens
force-pushed
the
ft-fallback-certkey
branch
from
c6fbdf3 to
ee8c821
Compare
andsens
changed the title
This primarily becomes relevant when the CA key is backed by a KMS like a TPM chip or a YubiKey
andsens
force-pushed
the
ft-fallback-certkey
branch
from
ee8c821 to
d46d54d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily becomes relevant when the CA key is backed by a KMS like a TPM chip or a YubiKey (like in this project).
I have kept the PR intentionally simple for now. I'm guessing we need some tests, and perhaps logging that we are using a fallback could be relevant.
Note that the
rand.Read()makes the key generation for certificates non-deterministic and might also affect performance when connecting for the first time (assumingCertStorageis used).