Ensure IDs rather than hrefs are stripped, closes #2175

Author: josevalim

lib/ex_doc/doc_ast.ex

@@ -171,12 +171,9 @@ defmodule ExDoc.DocAST do
   def synopsis([head | _]), do: synopsis(head)
   def synopsis(_other), do: ""
 
-  @doc """
-  Remove ids from elements.
-  """
-  def remove_ids(ast) do
+  defp remove_ids(ast) do
     map_tags(ast, fn {tag, attrs, inner, meta} ->
-      {tag, Keyword.delete(attrs, :href), inner, meta}
+      {tag, Keyword.delete(attrs, :id), inner, meta}
     end)
   end
 

test/ex_doc/doc_ast_test.exs

@@ -98,10 +98,16 @@ defmodule ExDoc.DocASTTest do
   describe "synopsis" do
     test "functionality" do
       assert synopsis("") == ""
-      assert synopsis("<p>.</p>") == "<p>.</p>"
-      assert synopsis("<p>::</p>") == "<p></p>"
-      assert synopsis("<p>Description:</p>") == "<p>Description</p>"
-      assert synopsis("<p>abcd</p>") == "<p>abcd</p>"
+      assert synopsis(".") == "<p>.</p>"
+      assert synopsis("::") == "<p></p>"
+      assert synopsis("abcd") == "<p>abcd</p>"
+      assert synopsis("Description:") == "<p>Description</p>"
+
+      assert synopsis("[Access](Access.html)") ==
+               "<p><a href=\"Access.html\">Access</a></p>"
+
+      assert synopsis("[Access](Access.html) {: #foo}") ==
+               "<p><a href=\"Access.html\">Access</a></p>"
     end
 
     test "should not end have trailing periods or semicolons" do