Prevent multiple Start() calls across components

Author: julienrbrt

block/internal/cache/manager.go

@@ -246,13 +246,6 @@ func (m *implementation) CleanupOldTxs(olderThan time.Duration) int {
 		return true
 	})
 
-	if removed > 0 {
-		m.logger.Debug().
-			Int("removed", removed).
-			Dur("older_than", olderThan).
-			Msg("cleaned up old transaction hashes from cache")
-	}
-
 	return removed
 }
 

block/internal/executing/executor.go

@@ -163,6 +163,9 @@ func (e *Executor) SetBlockProducer(bp BlockProducer) {
 
 // Start begins the execution component
 func (e *Executor) Start(ctx context.Context) error {
+	if e.cancel != nil {
+		return errors.New("executor already started")
+	}
 	e.ctx, e.cancel = context.WithCancel(ctx)
 
 	// Initialize state

block/internal/pruner/pruner.go

@@ -52,6 +52,9 @@ func New(
 
 // Start begins the pruning loop.
 func (p *Pruner) Start(ctx context.Context) error {
+	if p.cancel != nil {
+		return errors.New("pruner already started")
+	}
 	if !p.cfg.IsPruningEnabled() {
 		p.logger.Info().Msg("pruning is disabled, not starting pruner")
 		return nil

block/internal/reaping/reaper.go

@@ -69,9 +69,11 @@ func NewReaper(
 
 // Start begins the execution component
 func (r *Reaper) Start(ctx context.Context) error {
+	if r.cancel != nil {
+		return errors.New("reaper already started")
+	}
 	r.ctx, r.cancel = context.WithCancel(ctx)
 
-	// Start reaper loop
 	r.wg.Go(r.reaperLoop)
 
 	r.logger.Info().Dur("idle_interval", r.interval).Msg("reaper started")

block/internal/submitting/submitter.go

@@ -119,6 +119,9 @@ func NewSubmitter(
 
 // Start begins the submitting component
 func (s *Submitter) Start(ctx context.Context) error {
+	if s.cancel != nil {
+		return errors.New("submitter already started")
+	}
 	s.ctx, s.cancel = context.WithCancel(ctx)
 
 	// Initialize DA included height

block/internal/syncing/syncer.go

@@ -163,6 +163,9 @@ func (s *Syncer) SetBlockSyncer(bs BlockSyncer) {
 
 // Start begins the syncing component
 func (s *Syncer) Start(ctx context.Context) (err error) {
+	if s.cancel != nil {
+		return errors.New("syncer already started")
+	}
 	ctx, cancel := context.WithCancel(ctx)
 	s.ctx, s.cancel = ctx, cancel