Repository navigation
Compatibility with click v8.4.0 #1939
Replies: 3 comments
|
I'm not sure I understand. Typer has vendored Click and shouldn't be using Click directly anymore. The error messages should be defined within Typer's code base. Which version of Typer are you using? Happy to continue discussing here, but please don't create a PR yet. |
0 replies
|
Sorry; I had incorrectly been using Nix's facilities for installing packages (which injected |
0 replies
|
Ok, thanks for reporting back! |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
First Check
Example Code
Description
clickv8.4.0 made a few changes that breaktyper's tests.All of the problematic changes are contained in pallets/click#3228.
for f in $(find tests -type f -print); do sed -i -E 's/"No such option: ([^"]*)"(.*)/"No such option: \1"\2 or "No such option '"'"'\1'"'"'"\2/g' "$f"; doneupdates all tests to support both the old and new errors.test_path_convert_failures(intests/test_type_conversion.py) andtest_not_exists(intests/test_tutorial/test_parameter_types/test_path/test_tutorial002.py) both now need to assert againstnormalize_rich_output(result.output, "")in their final assertions.typer.Typer'ssuggest_commands=Falseno longer works becauseclicknow handles this.I'd be happy to make a PR with the test fixes (I have them locally). For the
suggest_commandsoption, though, I'm not quite sure what to do with it. (I have the relevant test marked withpytest.mark.skipiflocally, but the condition for that requires using thepackagingpackage, which you won't accept from me per https://tiangolo.com/open-source/contributing/#dependencies.)Operating System
Linux
Operating System Details
No response
Project Version
master (9a7b2e8)
Python Version
3.10.20 and 3.14.7
Additional Context
No response
All reactions