Hot take PR: Use vlsvrs to read in compressed VDFs#430
Open
kstppd wants to merge 15 commits intofmihpc:masterfrom
Open
Hot take PR: Use vlsvrs to read in compressed VDFs#430kstppd wants to merge 15 commits intofmihpc:masterfrom
kstppd wants to merge 15 commits intofmihpc:masterfrom
Conversation
…terix_vlsvrs_vdfs
Contributor
Author
|
Apparently the test image CI test is supposed to fail right now so the PR looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this PR is a second attempt at reading in compressed VDFs produce by Asterix. In this attempt vlsvrs is used when VDFs are compressed. By default the supported methods
are :
MLP and MLP_MULTI are supported however you need to have asterix installed on your machine and prior to
pip install .you need to:export MLP_COMPRESSION_DIR=/path/to/asterix/.so/files.So in this case we have no python interfacing with any C/C++/CUDA libs since it is all done by vlsvrs.