fix(rust): a field that names its own struct needs a Box (+3) - #3378
Closed
gHashTag wants to merge 1 commit into
Closed
fix(rust): a field that names its own struct needs a Box (+3)#3378gHashTag wants to merge 1 commit into
gHashTag wants to merge 1 commit into
Conversation
gHashTag
enabled auto-merge (squash)
September 6, 2026 08:02
Owner
Author
|
Duplicate: master already emits The measurement stands and is worth recording: Not caught by |
auto-merge was automatically disabled
September 6, 2026 08:08
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3377
Chosen with
tri one-away, not guessed. It reportedrecursive type X has infinite sizeas the sole error of 3 specs whose count is exact; the repair moved exactly those 3. First fix in five passes to move the column.There is no version of this that compiles without indirection, so nothing is being chosen about representation — it is the difference between output and no output.
Boxis the ownership-preserving one of the three names rustc offers.Two shapes, and the second corrects a claim of mine.
Option<Name>is kd_tree.[Option<Name>; N]is octree and quadtree — and an earlier pass of mine wroteoctree.t27off as "genuinely infinitely sized". It is not: an array is inline storage, only the element needs the box, and[Option<Box<OctNode>>; 8]is finite.Measured, two pinned binaries built from the same commit in one pass, 650 specs: 357 → 360, +3, zero regressions.
Nine structs in the corpus name themselves; three were one-away and are now green. Narrow on purpose:
Vec<Name>already carries its indirection and is untouched, and a shape this does not recognise keeps its current output rather than getting a guess.