BAD CODE™: replace the occurrence-authority string ratchet with AST semantics

[flyingrobots]

Classification

BAD CODE™ — structural test debt exposed by review of #838.

Problem

test/unit/scripts/entity-capture-type-assertion-ratchet.test.ts currently protects the occurrence-authority boundary with a literal source-substring assertion:

expect(occurrence).not.toContain("issued.subject === occurrence.subject");

Whitespace, parentheses, or reversing the equality operands can restore the forbidden semantic coupling without tripping that ratchet. The same test already imports the TypeScript compiler API, so a syntax-dependent text check is below the established structural-testing standard.

Required correction

• Parse src/domain/api/EntityOccurrence.ts through the TypeScript AST.
• Detect equality comparisons between issued.subject and occurrence.subject regardless of operand order, whitespace, or parenthesization.
• Keep the existing prohibitions on hidden WeakMap authority and private comparison callbacks.
• Remove the literal source-text assertion once the semantic check exists.

Acceptance

• A regression fixture fails for issued.subject === occurrence.subject.
• A regression fixture fails for occurrence.subject===issued.subject.
• The current occurrence-owned authority implementation passes.
• The focused ratchet test and npm run test:fast pass.

Related: #838.

[coderabbitai]

🔗 Related PRs

#656 - Clean up first static-text witness batch [closed]
#657 - Pay down static text witness batch A [closed]
#660 - Replace static assertion batch 4 [merged]
#789 - Publish v19 charts and testing surfaces [merged]
#838 - Expose causal entity occurrences and substrate allocation [open]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

• Create Plan

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!