Replace IfStmt.getCond with IfStmt.getCondition

Author: owen-mc

go/ql/lib/semmle/go/Stmt.qll

@@ -710,8 +710,11 @@ class IfStmt extends @ifstmt, Stmt, ScopeNode {
   /** Gets the init statement of this `if` statement, if any. */
   Stmt getInit() { result = this.getChildStmt(0) }
 
+  /** DEPRECATED: Use `getCondition` instead. */
+  deprecated Expr getCond() { result = this.getCondition() }
+
   /** Gets the condition of this `if` statement. */
-  Expr getCond() { result = this.getChildExpr(1) }
+  Expr getCondition() { result = this.getChildExpr(1) }
 
   /** Gets the "then" branch of this `if` statement. */
   BlockStmt getThen() { result = this.getChildStmt(2) }
@@ -721,7 +724,7 @@ class IfStmt extends @ifstmt, Stmt, ScopeNode {
 
   override predicate mayHaveSideEffects() {
     this.getInit().mayHaveSideEffects() or
-    this.getCond().mayHaveSideEffects() or
+    this.getCondition().mayHaveSideEffects() or
     this.getThen().mayHaveSideEffects() or
     this.getElse().mayHaveSideEffects()
   }

go/ql/lib/semmle/go/controlflow/ControlFlowGraph.qll

@@ -118,7 +118,7 @@ module ControlFlow {
     or
     expr = any(ForStmt fs).getCond()
     or
-    expr = any(IfStmt is).getCond()
+    expr = any(IfStmt is).getCondition()
     or
     isExpressionlessSwitchCaseCondition(expr)
   }

go/ql/lib/semmle/go/controlflow/IR.qll

@@ -29,7 +29,7 @@ module IR {
    * `LogicalBinaryExpr`.
    */
   private predicate isInBooleanCondContext(Expr e) {
-    e = any(IfStmt s).getCond()
+    e = any(IfStmt s).getCondition()
     or
     e = any(ForStmt s).getCond()
     or

go/ql/src/RedundantCode/DuplicateBranches.ql

@@ -23,4 +23,4 @@ where
   thenBranch = is.getThen() and
   elseBranch = is.getElse() and
   thenBranch.hash() = elseBranch.hash()
-select is.getCond(), "The 'then' and 'else' branches of this if statement are identical."
+select is.getCondition(), "The 'then' and 'else' branches of this if statement are identical."

go/ql/src/RedundantCode/DuplicateCondition.ql

@@ -16,7 +16,7 @@ import go
 
 /** Gets the `i`th condition in the `if`-`else if` chain starting at `stmt`. */
 Expr getCondition(IfStmt stmt, int i) {
-  i = 0 and result = stmt.getCond()
+  i = 0 and result = stmt.getCondition()
   or
   exists(IfStmt elsif | elsif = stmt.getElse() |
     not exists(elsif.getInit()) and

go/ql/src/RedundantCode/UnreachableStatement.ql

@@ -90,7 +90,7 @@ predicate allowlist(Stmt s) {
   or
   // statements deliberately made unreachable by a constant condition, such as the code
   // following `if true { return }`
-  exists(getPreviousStmt(s).(IfStmt).getCond().getBoolValue())
+  exists(getPreviousStmt(s).(IfStmt).getCondition().getBoolValue())
 }
 
 from Stmt s

go/ql/src/experimental/CWE-942/CorsMisconfiguration.ql

@@ -176,7 +176,7 @@ module FromUntrustedConfig implements DataFlow::ConfigSig {
   additional predicate isSinkCgn(DataFlow::Node sink, ControlFlow::ConditionGuardNode cgn) {
     exists(IfStmt ifs |
       exists(Expr operand |
-        operand = ifs.getCond().getAChildExpr*() and
+        operand = ifs.getCondition().getAChildExpr*() and
         (
           exists(DataFlow::CallExpr call | call = operand |
             call.getTarget().hasQualifiedName("strings", "HasSuffix") and
@@ -202,7 +202,7 @@ module FromUntrustedConfig implements DataFlow::ConfigSig {
         )
       )
     |
-      cgn.getCondition() = ifs.getCond()
+      cgn.getCondition() = ifs.getCondition()
     )
   }
 }