Repository navigation
feat(google/shopping/merchant/reviews/v1): onboard a new library - #9691
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the v1 version of the ProductReviewsService for the Google Shopping Merchant Reviews API, adding the corresponding proto definitions, generated client libraries, samples, and tests. Feedback on the changes suggests reverting the modification of name_pretty in .repo-metadata.json from "Merchant" back to "Shopping Merchant Reviews" to prevent confusion and display issues in the generated documentation index.
Member
Author
|
Hi @shivanee-p @quirogas, could you please take a look at this library onboarding PR when you get a chance? Thanks! |
quirogas
self-requested a review
October 21, 2026 22:28
suztomo
marked this pull request as ready for review
October 21, 2026 22:34
quirogas
approved these changes
Oct 21, 2026
suztomo
force-pushed
the
onboard-shopping-merchant-reviews-v1
branch
from
October 22, 2026 15:59
7383d45 to
a6ac8dd
Compare
shivanee-p
approved these changes
Oct 22, 2026
suztomo
marked this pull request as draft
October 22, 2026 16:46
b/574419394 PiperOrigin-RevId: 1000790478
suztomo
force-pushed
the
onboard-shopping-merchant-reviews-v1
branch
from
October 22, 2026 16:54
0a58a4f to
80e62ac
Compare
Member
Author
|
I think it's better to use name_pretty_override in librarian.yaml temporarily until googleapis/librarian#7805 lands. |
suztomo
marked this pull request as ready for review
October 22, 2026 17:05
Member
Author
quirogas
added a commit
that referenced
this pull request
Oct 22, 2026
…9698) ## Description Configure `name_pretty_override` for all 14 Shopping Merchant packages in `librarian.yaml`. ## Impact Prevents Librarian from overwriting Shopping Merchant `name_pretty` values with `"Merchant"`. ## Changes - Add `nodejs.name_pretty_override` (`Shopping Merchant <Subproduct>`) to all 14 `google-shopping-merchant-*` library entries in `librarian.yaml` so Librarian does not default to `cleanTitle(api.Title)` (`"Merchant"`) from the shared `google/shopping/merchant/v1/merchantapi_v1.yaml` service config. - Regenerate all 14 `google-shopping-merchant-*` libraries using the Librarian CLI (`v0.49.0`), which updates `packages/google-shopping-merchant-loyaltycustomers/.repo-metadata.json` `name_pretty` from `"Merchant"` to `"Shopping Merchant Loyalty Customers"`. ## Testing - Ran `librarian tidy` and `librarian install` (`v0.49.0`, Node.js `v22.23.2`, `pnpm` `10.34.6`). - Ran `librarian generate <lib>` across all 14 `google-shopping-merchant-*` packages. - Verified that the 13 Merchant packages that already had `"Shopping Merchant <Subproduct>"` regenerated with zero diff, and `google-shopping-merchant-loyaltycustomers/.repo-metadata.json` updated cleanly to `"Shopping Merchant Loyalty Customers"`. ## Alternatives - Manually reverting `.repo-metadata.json` on every Librarian regeneration or onboarding PR (as in #9691) was rejected because weekly API source updates and Librarian version bumps will repeatedly overwrite `name_pretty` back to `"Merchant"` without `name_pretty_override` in `librarian.yaml`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onboard google/shopping/merchant/reviews/v1 API (google-shopping-merchant-reviews).
Internal tracking bug http://b/574419394
PiperOrigin-RevId: 1000790478
Debug Info
System Details
Commands Executed
go run github.com/googleapis/librarian/cmd/librarian@v0.49.0 installgo run github.com/googleapis/librarian/cmd/librarian@v0.49.0 add google/shopping/merchant/reviews/v1go run github.com/googleapis/librarian/cmd/librarian@v0.49.0 generate google-shopping-merchant-reviewsgo run github.com/googleapis/librarian/cmd/librarian@v0.49.0 tidygit add .b/574419394
PiperOrigin-RevId: 1000790478"`