Skip to content

Commit 32d8aa1

Browse files
suztomosuztomo
authored
chore: remove build badges in README.md template (#4027)
Removes old badge references in the README.md template We will stop using the public GCS buckets (b/468377909), where we currently store the build badges. The template in sdk-platform-java referenced the badges in the bucket. In the monorepo generation test, I had to disable the README comparison check with google-cloud-java, because google-cloud-java hasn't received the updates from this change yet.
1 parent b68791d commit 32d8aa1

File tree

5 files changed

+4
-71
lines changed

5 files changed

+4
-71
lines changed

‎.cloudbuild/library_generation/scripts/integration_tests.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,10 @@ def test_monorepo_generation(self):
4343
compare_result = dircmp(
4444
f"{golden_dir}/{library_name}",
4545
actual_library,
46-
ignore=[".repo-metadata.json"],
46+
# README.md is ignored because the golden files in the
47+
# google-cloud-java repository still contain the old build badges.
48+
# TODO: Remove README.md from ignore list once golden files are updated.
49+
ignore=[".repo-metadata.json", "README.md"],
4750
)
4851
diff_files = []
4952
golden_only = []

‎hermetic_build/library_generation/owlbot/templates/java_library/README.md‎

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -238,30 +238,10 @@ information.
238238

239239
Apache 2.0 - See [LICENSE][license] for more information.
240240

241-
## CI Status
242-
243-
Java Version | Status
244-
------------ | ------{% if metadata['min_java_version'] <= 7 %}
245-
Java 7 | [![Kokoro CI][kokoro-badge-image-1]][kokoro-badge-link-1]{% endif %}
246-
Java 8 | [![Kokoro CI][kokoro-badge-image-2]][kokoro-badge-link-2]
247-
Java 8 OSX | [![Kokoro CI][kokoro-badge-image-3]][kokoro-badge-link-3]
248-
Java 8 Windows | [![Kokoro CI][kokoro-badge-image-4]][kokoro-badge-link-4]
249-
Java 11 | [![Kokoro CI][kokoro-badge-image-5]][kokoro-badge-link-5]
250-
251241
Java is a registered trademark of Oracle and/or its affiliates.
252242

253243
[product-docs]: {{metadata['repo']['product_documentation']}}
254244
[javadocs]: {{metadata['repo']['client_documentation']}}
255-
[kokoro-badge-image-1]: http://storage.googleapis.com/cloud-devrel-public/java/badges/{{ repo_short }}/java7.svg
256-
[kokoro-badge-link-1]: http://storage.googleapis.com/cloud-devrel-public/java/badges/{{ repo_short }}/java7.html
257-
[kokoro-badge-image-2]: http://storage.googleapis.com/cloud-devrel-public/java/badges/{{ repo_short }}/java8.svg
258-
[kokoro-badge-link-2]: http://storage.googleapis.com/cloud-devrel-public/java/badges/{{ repo_short }}/java8.html
259-
[kokoro-badge-image-3]: http://storage.googleapis.com/cloud-devrel-public/java/badges/{{ repo_short }}/java8-osx.svg
260-
[kokoro-badge-link-3]: http://storage.googleapis.com/cloud-devrel-public/java/badges/{{ repo_short }}/java8-osx.html
261-
[kokoro-badge-image-4]: http://storage.googleapis.com/cloud-devrel-public/java/badges/{{ repo_short }}/java8-win.svg
262-
[kokoro-badge-link-4]: http://storage.googleapis.com/cloud-devrel-public/java/badges/{{ repo_short }}/java8-win.html
263-
[kokoro-badge-image-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/{{ repo_short }}/java11.svg
264-
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/{{ repo_short }}/java11.html
265245
[stability-image]: https://img.shields.io/badge/stability-{% if metadata['repo']['release_level'] == 'stable' %}stable-green{% elif metadata['repo']['release_level'] == 'preview' %}preview-yellow{% else %}unknown-red{% endif %}
266246
[maven-version-image]: https://img.shields.io/maven-central/v/{{ group_id }}/{{ artifact_id }}.svg
267247
[maven-version-link]: https://central.sonatype.com/artifact/{{ group_id }}/{{ artifact_id }}/{{ version }}

‎hermetic_build/library_generation/tests/resources/test-owlbot/testdata/README-golden.md‎

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -153,29 +153,10 @@ information.
153153

154154
Apache 2.0 - See [LICENSE][license] for more information.
155155

156-
## CI Status
157-
158-
Java Version | Status
159-
------------ | ------
160-
Java 8 | [![Kokoro CI][kokoro-badge-image-2]][kokoro-badge-link-2]
161-
Java 8 OSX | [![Kokoro CI][kokoro-badge-image-3]][kokoro-badge-link-3]
162-
Java 8 Windows | [![Kokoro CI][kokoro-badge-image-4]][kokoro-badge-link-4]
163-
Java 11 | [![Kokoro CI][kokoro-badge-image-5]][kokoro-badge-link-5]
164-
165156
Java is a registered trademark of Oracle and/or its affiliates.
166157

167158
[product-docs]: https://cloud.google.com/resource-manager/docs/cloud-asset-inventory/overview
168159
[javadocs]: https://googleapis.dev/java/google-cloud-asset/latest/index.html
169-
[kokoro-badge-image-1]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-asset/java7.svg
170-
[kokoro-badge-link-1]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-asset/java7.html
171-
[kokoro-badge-image-2]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-asset/java8.svg
172-
[kokoro-badge-link-2]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-asset/java8.html
173-
[kokoro-badge-image-3]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-asset/java8-osx.svg
174-
[kokoro-badge-link-3]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-asset/java8-osx.html
175-
[kokoro-badge-image-4]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-asset/java8-win.svg
176-
[kokoro-badge-link-4]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-asset/java8-win.html
177-
[kokoro-badge-image-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-asset/java11.svg
178-
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-asset/java11.html
179160
[stability-image]: https://img.shields.io/badge/stability-stable-green
180161
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-asset.svg
181162
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-asset/1.2.3

‎java-core/README.md‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,6 @@ considered stable.
3333

3434
Apache 2.0 - See [LICENSE][license] for more information.
3535

36-
## CI Status
37-
38-
Java Version | Status
39-
------------ | ------
40-
Java 7 | [![Kokoro CI](https://storage.googleapis.com/cloud-devrel-public/java/badges/java-core/java7.svg)](https://storage.googleapis.com/cloud-devrel-public/java/badges/java-core/java7.html)
41-
Java 8 | [![Kokoro CI](https://storage.googleapis.com/cloud-devrel-public/java/badges/java-core/java8.svg)](https://storage.googleapis.com/cloud-devrel-public/java/badges/java-core/java8.html)
42-
Java 8 OSX | [![Kokoro CI](https://storage.googleapis.com/cloud-devrel-public/java/badges/java-core/java8-osx.svg)](https://storage.googleapis.com/cloud-devrel-public/java/badges/java-core/java8-osx.html)
43-
Java 8 Windows | [![Kokoro CI](https://storage.googleapis.com/cloud-devrel-public/java/badges/java-core/java8-win.svg)](https://storage.googleapis.com/cloud-devrel-public/java/badges/java-core/java8-win.html)
44-
Java 11 | [![Kokoro CI](https://storage.googleapis.com/cloud-devrel-public/java/badges/java-core/java11.svg)](https://storage.googleapis.com/cloud-devrel-public/java/badges/java-core/java11.html)
45-
46-
4736
[contributing]: https://github.com/googleapis/java-core/blob/main/CONTRIBUTING.md
4837
[code-of-conduct]: https://github.com/googleapis/java-core/blob/main/CODE_OF_CONDUCT.md
4938
[license]: https://github.com/googleapis/java-core/blob/main/LICENSE

‎java-iam/README.md‎

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -22,27 +22,7 @@ and the public API should not be considered stable.
2222

2323
Apache 2.0 - See [LICENSE][license] for more information.
2424

25-
## CI Status
26-
27-
| Java Version | Status |
28-
| -------------- | --------------------------------------------------------- |
29-
| Java 7 | [![Kokoro CI][kokoro-badge-image-1]][kokoro-badge-link-1] |
30-
| Java 8 | [![Kokoro CI][kokoro-badge-image-2]][kokoro-badge-link-2] |
31-
| Java 8 OSX | [![Kokoro CI][kokoro-badge-image-3]][kokoro-badge-link-3] |
32-
| Java 8 Windows | [![Kokoro CI][kokoro-badge-image-4]][kokoro-badge-link-4] |
33-
| Java 11 | [![Kokoro CI][kokoro-badge-image-5]][kokoro-badge-link-5] |
34-
3525
[javadocs]: https://googleapis.dev/java/google-iam/latest/index.html
36-
[kokoro-badge-image-1]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-iam/java7.svg
37-
[kokoro-badge-link-1]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-iam/java7.html
38-
[kokoro-badge-image-2]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-iam/java8.svg
39-
[kokoro-badge-link-2]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-iam/java8.html
40-
[kokoro-badge-image-3]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-iam/java8-osx.svg
41-
[kokoro-badge-link-3]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-iam/java8-osx.html
42-
[kokoro-badge-image-4]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-iam/java8-win.svg
43-
[kokoro-badge-link-4]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-iam/java8-win.html
44-
[kokoro-badge-image-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-iam/java11.svg
45-
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/java-iam/java11.html
4626
[stability-image]: https://img.shields.io/badge/stability-ga-green
4727
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.api.grpc/proto-google-iam-v1.svg
4828
[maven-version-link]: https://search.maven.org/search?q=g:com.google.api.grpc%20AND%20a:proto-google-iam-v1&core=gav

0 commit comments

Comments
 (0)