Skip to content

Commit 760f166

Browse files
committed
Clean up obsolete CPP for base<4.11
1 parent 305d138 commit 760f166

10 files changed

Lines changed: 9 additions & 56 deletions

File tree

‎cbits/utils.c‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,6 @@
77
#include <string.h>
88
#include <sys/types.h>
99

10-
/* Changed name to disambiguate from _hs_text_memcmp,
11-
which could be present in system-wide headers from installed ghc package */
12-
int _hs_text_memcmp2(const void *arr1, size_t off1, const void *arr2, size_t off2, size_t len)
13-
{
14-
return memcmp(arr1 + off1, arr2 + off2, len);
15-
}
16-
1710
ssize_t _hs_text_memchr(const void *arr, size_t off, size_t len, uint8_t byte)
1811
{
1912
const void *ptr = memchr(arr + off, byte, len);

‎src/Data/Text/Array.hs‎

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
{-# LANGUAGE BangPatterns #-}
21
{-# LANGUAGE CPP #-}
32
{-# LANGUAGE MagicHash #-}
43
{-# LANGUAGE PatternSynonyms #-}
54
{-# LANGUAGE RankNTypes #-}
6-
{-# LANGUAGE RecordWildCards #-}
75
{-# LANGUAGE UnboxedTuples #-}
86
{-# LANGUAGE UnliftedFFITypes #-}
97

108
{-# OPTIONS_GHC -fno-warn-unused-matches #-}
9+
{- HLINT ignore "Redundant guard" -}
10+
1111
-- |
1212
-- Module : Data.Text.Array
1313
-- Copyright : (c) 2009, 2010, 2011 Bryan O'Sullivan
@@ -61,9 +61,6 @@ module Data.Text.Array
6161
#if defined(ASSERTS)
6262
import GHC.Stack (HasCallStack)
6363
#endif
64-
#if !MIN_VERSION_base(4,11,0)
65-
import Foreign.C.Types (CInt(..))
66-
#endif
6764
import GHC.Exts hiding (toList)
6865
import GHC.ST (ST(..), runST)
6966
import GHC.Word (Word8(..))
@@ -350,12 +347,5 @@ compareInternal
350347
-> Int
351348
compareInternal (ByteArray src1#) (I# off1#) (ByteArray src2#) (I# off2#) (I# count#) = i
352349
where
353-
#if MIN_VERSION_base(4,11,0)
354350
i = I# (compareByteArrays# src1# off1# src2# off2# count#)
355-
#else
356-
i = fromIntegral (memcmp src1# off1# src2# off2# count#)
357-
358-
foreign import ccall unsafe "_hs_text_memcmp2" memcmp
359-
:: ByteArray# -> Int# -> ByteArray# -> Int# -> Int# -> CInt
360-
#endif
361351
{-# INLINE compareInternal #-}

‎src/Data/Text/Internal/Builder.hs‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,6 @@ module Data.Text.Internal.Builder
6060

6161
import Control.Monad.ST (ST, runST)
6262
import Data.Monoid (Monoid(..))
63-
#if !MIN_VERSION_base(4,11,0)
64-
import Data.Semigroup (Semigroup(..))
65-
#endif
6663
import Data.Text.Internal (Text(..), safe)
6764
import Data.Text.Internal.Lazy (smallChunkSize)
6865
import Data.Text.Unsafe (inlineInterleaveST)

‎src/Data/Text/Internal/Builder/Functions.hs‎

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,20 +21,10 @@ module Data.Text.Internal.Builder.Functions
2121
, i2d
2222
) where
2323

24-
import Data.Monoid (mappend)
25-
import Data.Text.Lazy.Builder (Builder)
2624
import GHC.Base (chr#,ord#,(+#),Int(I#),Char(C#))
27-
import Prelude ()
25+
import Prelude ((<>))
2826

2927
-- | Unsafe conversion for decimal digits.
3028
{-# INLINE i2d #-}
3129
i2d :: Int -> Char
3230
i2d (I# i#) = C# (chr# (ord# '0'# +# i#))
33-
34-
-- | The normal 'mappend' function with right associativity instead of
35-
-- left.
36-
(<>) :: Builder -> Builder -> Builder
37-
(<>) = mappend
38-
{-# INLINE (<>) #-}
39-
40-
infixr 4 <>

‎src/Data/Text/Internal/Encoding.hs‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@ import Control.Exception (assert)
4242
#endif
4343
import Data.Bits ((.&.), shiftL, shiftR)
4444
import Data.ByteString (ByteString)
45-
#if !MIN_VERSION_base(4,11,0)
46-
import Data.Semigroup (Semigroup(..))
47-
#endif
4845
import Data.Word (Word32, Word8)
4946
import Foreign.Storable (pokeElemOff)
5047
import Data.Text.Encoding.Error (OnDecodeError)

‎src/Data/Text/Internal/StrictBuilder.hs‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
{-# LANGUAGE CPP #-}
21
{-# LANGUAGE BangPatterns #-}
32
{-# LANGUAGE RankNTypes #-}
43
{-# LANGUAGE TypeSynonymInstances #-}
@@ -32,9 +31,6 @@ import Control.Monad.ST.Unsafe (unsafeIOToST, unsafeSTToIO)
3231
import Data.Functor (void)
3332
import Data.Word (Word8)
3433
import Data.ByteString (ByteString)
35-
#if !MIN_VERSION_base(4,11,0)
36-
import Data.Semigroup (Semigroup(..))
37-
#endif
3834
import Data.Text.Internal (Text(..), empty, safe)
3935
import Data.Text.Internal.ByteStringCompat (withBS)
4036
import Data.Text.Internal.Encoding.Utf8 (utf8Length)

‎src/Data/Text/Lazy.hs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,6 @@ import GHC.Stack (HasCallStack)
261261
import qualified Language.Haskell.TH.Lift as TH
262262
#else
263263
import qualified Language.Haskell.TH.Syntax as TH
264-
import qualified Language.Haskell.TH.Lib as TH
265264
#endif
266265
import Text.Printf (PrintfArg, formatArg, formatString)
267266

‎src/Data/Text/Lazy/Builder/Int.hs‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
{-# LANGUAGE BangPatterns, CPP, MagicHash, RankNTypes, ScopedTypeVariables,
2-
UnboxedTuples #-}
1+
{-# LANGUAGE BangPatterns, RankNTypes, ScopedTypeVariables #-}
32
{-# LANGUAGE Trustworthy #-}
43

54
-- Module: Data.Text.Lazy.Builder.Int
@@ -20,16 +19,13 @@ module Data.Text.Lazy.Builder.Int
2019
import Data.Int (Int8, Int16, Int32, Int64)
2120
import Data.Monoid (mempty)
2221
import qualified Data.ByteString.Unsafe as B
23-
import Data.Text.Internal.Builder.Functions ((<>), i2d)
22+
import Data.Text.Internal.Builder.Functions (i2d)
2423
import Data.Text.Internal.Builder
2524
import Data.Text.Internal.Builder.Int.Digits (digits)
2625
import Data.Text.Array
2726
import Data.Word (Word, Word8, Word16, Word32, Word64)
2827
import GHC.Base (quotInt, remInt)
2928
import Control.Monad.ST
30-
#if MIN_VERSION_base(4,11,0)
31-
import Prelude hiding ((<>))
32-
#endif
3329

3430
decimal :: Integral a => a -> Builder
3531
{-# RULES "decimal/Int8" decimal = boundedDecimal :: Int8 -> Builder #-}

‎src/Data/Text/Lazy/Builder/RealFloat.hs‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
{-# LANGUAGE CPP, OverloadedStrings #-}
1+
{-# LANGUAGE OverloadedStrings #-}
22
{-# LANGUAGE Trustworthy #-}
33

44
{-# OPTIONS_GHC -Wno-unrecognised-warning-flags #-}
55
{-# OPTIONS_GHC -Wno-x-partial #-}
6+
{- HLINT ignore "Use guards" -}
67

78
-- |
89
-- Module: Data.Text.Lazy.Builder.RealFloat
@@ -20,14 +21,11 @@ module Data.Text.Lazy.Builder.RealFloat
2021

2122
import Data.Array.Base (unsafeAt)
2223
import Data.Array.IArray
23-
import Data.Text.Internal.Builder.Functions ((<>), i2d)
24+
import Data.Text.Internal.Builder.Functions (i2d)
2425
import Data.Text.Lazy.Builder.Int (decimal)
2526
import Data.Text.Internal.Builder.RealFloat.Functions (roundTo)
2627
import Data.Text.Lazy.Builder
2728
import qualified Data.Text as T
28-
#if MIN_VERSION_base(4,11,0)
29-
import Prelude hiding ((<>))
30-
#endif
3129

3230
-- | Control the rendering of floating point numbers.
3331
data FPFormat = Exponent

‎tests/Tests/Properties/Transcoding.hs‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
-- | Tests for encoding and decoding
22

3-
{-# LANGUAGE CPP, OverloadedStrings, ScopedTypeVariables #-}
3+
{-# LANGUAGE OverloadedStrings, ScopedTypeVariables #-}
44
{-# OPTIONS_GHC -Wno-missing-signatures #-}
55
{-# OPTIONS_GHC -Wno-unrecognised-warning-flags #-}
66
{-# OPTIONS_GHC -Wno-x-partial #-}
@@ -14,9 +14,6 @@ import Data.Bits ((.&.), shiftR)
1414
import Data.Char (chr, ord)
1515
import Data.Functor (void)
1616
import Data.Maybe (isNothing)
17-
#if !MIN_VERSION_base(4,11,0)
18-
import Data.Semigroup ((<>))
19-
#endif
2017
import Data.Word (Word8)
2118
import Test.QuickCheck hiding ((.&.))
2219
import Test.Tasty (TestTree, testGroup)

0 commit comments

Comments
 (0)