[Cleanup] Sorting Dropdowns Invoices/Clients

[Civolilah]

@beganovich @turbo124 This PR includes refactoring of the UX for applying invoices on the payment page. Screenshot:

Let me know your thoughts.

[turbo124]

@Civolilah looks good.

What happens if there are thousands of invoices, do we only pull back a limited set? if we sort by date, does it requery the results based on sort|date|asc|desc?

[Civolilah]

@Civolilah looks good.

What happens if there are thousands of invoices, do we only pull back a limited set? if we sort by date, does it requery the results based on sort|date|asc|desc?

@turbo124 So, right now we pull 1000 invoices here, and yes, just as for regular tables, sorting by any column works, so I just pulled 1000 invoices and removed pagination. I assumed it was enough. What do you think?

[turbo124]

@Civolilah

Thanks for the update. Can we also use this format format for the create payment page too?

[Civolilah]

@Civolilah

Thanks for the update. Can we also use this format format for the create payment page too?

@turbo124 Sure thing, I've refactored the create page as well. Screenshot:

Let me know your thoughts.

[turbo124]

@Civolilah

When using the apply credit option, the credit is not selected (nor visible for selection)

[Civolilah]

@Civolilah

When using the apply credit option, the credit is not selected (nor visible for selection)

@turbo124 Yes, you're right, "Apply Credit" and "Enter Payment" were not covered. I've made those logic adjustments now. Let me know your thoughts.

[turbo124]

Tracking revision in RU-2052

[Civolilah]

Tracking revision in RU-2052

@turbo124 I gave comment on: https://invoiceninja.atlassian.net/browse/RU-2052 and the implementations are also pushed to this PR. Let me know your thoughts.

[turbo124]

@Civolilah

if i istart filtering, and the filter returns 0 results... i think get this, which is irreversible

[Civolilah]

@Civolilah

if i istart filtering, and the filter returns 0 results... i think get this, which is irreversible

@turbo124 Ah sure, that's my bad, but if we want to have this empty state that is not a classic empty state in the table, we must be aware that the filter field must be displayed. Because we can't determine the reason there are 0 results, is it the search or are there just no results. Screenshot:

Let me know your thoughts.

[turbo124]

@Civolilah ok, lets add back the filter

[Civolilah]

@turbo124 As we discussed on Slack, error messages for number input fields in the invoices/credits table have been redesigned. Screenshot:

Let me know your thoughts.

[Civolilah]

@turbo124 As we discussed on the Slack error messages under table fields have been adjusted here. Please let me know if you see any issues or if you have any additional suggestions.

[turbo124]

@Civolilah i am seeing issues with the currency formatting of the amounts here. They are not consistent for what should be displayed for the client?