[REFACTOR] Config File: get rid of nodefilters in favor of node lists… #1630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new configuration file format (v1alpha6) that replaces the confusing
nodeFilterssyntax with explicit node definitions. The new format uses anodesarray where each node configuration is self-contained, making configurations more readable and easier to understand.Key Changes:
servers/agentscounts withnodesarray containingrole,name, andreplicasnodeFiltersto individual node configsBreaking Changes
Migration Path
servers/agentscounts to explicit node definitionsnodeFiltersare resolved and applied to specific nodes during migrationInternal Changes (pkg/)
Future Considerations
Files Added/Modified
pkg/config/v1alpha6/types.go- New configuration typespkg/config/v1alpha6/migrations.go- Migration logic from v1alpha5pkg/config/v1alpha6/schema.json- JSON schema for validationpkg/config/transform_v1alpha6.go- Transform logic for new formatexample-v1alpha6.yaml- Example configuration demonstrating new syntaxTesting