Skip to content

Commit 074b2ad

Browse files
Merge pull request #181 from keepkey/fix/bip85-message-gate
fix: add requires_message gate to BIP-85 tests
2 parents 04ef8e7 + 2af7352 commit 074b2ad

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

tests/test_msg_bip85.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,24 +17,26 @@
1717

1818
class TestMsgBip85(common.KeepKeyTest):
1919

20-
def test_bip85_12word_flow(self):
20+
def setUp(self):
21+
super().setUp()
2122
self.requires_firmware("7.14.0")
23+
self.requires_message("GetBip85Mnemonic")
24+
25+
def test_bip85_12word_flow(self):
2226
"""12-word derivation: verify device goes through display flow and returns Success."""
2327
self.setup_mnemonic_allallall()
2428

2529
resp = self.client.call(proto.GetBip85Mnemonic(word_count=12, index=0))
2630
self.assertIsInstance(resp, proto.Success)
2731

2832
def test_bip85_24word_flow(self):
29-
self.requires_firmware("7.14.0")
3033
"""24-word derivation: verify display flow and Success."""
3134
self.setup_mnemonic_allallall()
3235

3336
resp = self.client.call(proto.GetBip85Mnemonic(word_count=24, index=0))
3437
self.assertIsInstance(resp, proto.Success)
3538

3639
def test_bip85_different_indices_different_flows(self):
37-
self.requires_firmware("7.14.0")
3840
"""Index 0 and index 1 must both succeed."""
3941
self.setup_mnemonic_allallall()
4042

@@ -43,7 +45,6 @@ def test_bip85_different_indices_different_flows(self):
4345
self.assertIsInstance(resp, proto.Success)
4446

4547
def test_bip85_invalid_word_count(self):
46-
self.requires_firmware("7.14.0")
4748
"""Invalid word_count (15) must be rejected by firmware."""
4849
self.setup_mnemonic_allallall()
4950

@@ -53,15 +54,13 @@ def test_bip85_invalid_word_count(self):
5354
self.assertIn('word_count', str(ctx.exception))
5455

5556
def test_bip85_18word_flow(self):
56-
self.requires_firmware("7.14.0")
5757
"""18-word derivation: verify the third word_count variant works."""
5858
self.setup_mnemonic_allallall()
5959

6060
resp = self.client.call(proto.GetBip85Mnemonic(word_count=18, index=0))
6161
self.assertIsInstance(resp, proto.Success)
6262

6363
def test_bip85_deterministic_flow(self):
64-
self.requires_firmware("7.14.0")
6564
"""Same parameters must produce identical results both times."""
6665
self.setup_mnemonic_allallall()
6766

0 commit comments

Comments
 (0)