goss containerd-wasm-shims validation fails if not all 4 shims are used

[simonostendorf]

Environment

• Make target: make build-hcloud-flatcar
• Run using container image? (Y/N): Y
• Environment vars:

HCLOUD_TOKEN=<>
HCLOUD_LOCATION=fsn1
PACKER_VAR_FILES=user_variables.json

• Vars file:

{
  "server_type": "cx22"
}

What steps did you take and what happened?

1. use default values of hcloud-packer that includes spin,slight (see https://github.com/kubernetes-sigs/image-builder/blob/main/images/capi/packer/hcloud/hcloud-config.json#L2)
2. build a new image using hcloud-build-flatcar
3. goss validation fails because lunatic and wws are not present (see log output)

What did you expect to happen?

I would expect that goss would only validate the needed wasm shims and not all 4.

Relevant log output

Log Output

    hcloud:         {
    hcloud:             "duration": 7292075,
    hcloud:             "err": null,
    hcloud:             "expected": [
    hcloud:                 "1"
    hcloud:             ],
    hcloud:             "found": [
    hcloud:                 "127"
    hcloud:             ],
    hcloud:             "human": "Expected\n    \u003cint\u003e: 127\nto equal\n    \u003cint\u003e: 1",
    hcloud:             "meta": null,
    hcloud:             "property": "exit-status",
    hcloud:             "resource-id": "containerd-shim-wws-v1",
    hcloud:             "resource-type": "Command",
    hcloud:             "result": 1,
    hcloud:             "successful": false,
    hcloud:             "summary-line": "Command: containerd-shim-wws-v1: exit-status:\nExpected\n    \u003cint\u003e: 127\nto equal\n    \u003cint\u003e: 1",
    hcloud:             "test-type": 0,
    hcloud:             "title": ""
    hcloud:         },
    hcloud:         {
    hcloud:             "duration": 23542,
    hcloud:             "err": null,
    hcloud:             "expected": [
    hcloud:                 "io.containerd.wws.v1: InvalidArgument(\"Shim namespace cannot be empty\")"
    hcloud:             ],
    hcloud:             "found": null,
    hcloud:             "human": "",
    hcloud:             "meta": null,
    hcloud:             "property": "stderr",
    hcloud:             "resource-id": "containerd-shim-wws-v1",
    hcloud:             "resource-type": "Command",
    hcloud:             "result": 1,
    hcloud:             "successful": false,
    hcloud:             "summary-line": "Command: containerd-shim-wws-v1: stderr: patterns not found: [io.containerd.wws.v1: InvalidArgument(\"Shim namespace cannot be empty\")]",
    hcloud:             "test-type": 2,
    hcloud:             "title": ""
    hcloud:         },
    hcloud:         {
    hcloud:             "duration": 14251841,
    hcloud:             "err": null,
    hcloud:             "expected": [
    hcloud:                 "1"
    hcloud:             ],
    hcloud:             "found": [
    hcloud:                 "127"
    hcloud:             ],
    hcloud:             "human": "Expected\n    \u003cint\u003e: 127\nto equal\n    \u003cint\u003e: 1",
    hcloud:             "meta": null,
    hcloud:             "property": "exit-status",
    hcloud:             "resource-id": "containerd-shim-lunatic-v1",
    hcloud:             "resource-type": "Command",
    hcloud:             "result": 1,
    hcloud:             "successful": false,
    hcloud:             "summary-line": "Command: containerd-shim-lunatic-v1: exit-status:\nExpected\n    \u003cint\u003e: 127\nto equal\n    \u003cint\u003e: 1",
    hcloud:             "test-type": 0,
    hcloud:             "title": ""
    hcloud:         },
    hcloud:         {
    hcloud:             "duration": 10335,
    hcloud:             "err": null,
    hcloud:             "expected": [
    hcloud:                 "io.containerd.lunatic.v1: InvalidArgument(\"Shim namespace cannot be empty\")"
    hcloud:             ],
    hcloud:             "found": null,
    hcloud:             "human": "",
    hcloud:             "meta": null,
    hcloud:             "property": "stderr",
    hcloud:             "resource-id": "containerd-shim-lunatic-v1",
    hcloud:             "resource-type": "Command",
    hcloud:             "result": 1,
    hcloud:             "successful": false,
    hcloud:             "summary-line": "Command: containerd-shim-lunatic-v1: stderr: patterns not found: [io.containerd.lunatic.v1: InvalidArgument(\"Shim namespace cannot be empty\")]",
    hcloud:             "test-type": 2,
    hcloud:             "title": ""
    hcloud:         },

Anything else you would like to add?

All other providers use all 4 wasm shims. I dont now why hcloud is not. Maybe this is the thing to fix. Or the goss validation should be adjusted.

---

/kind bug