Skip to content

Fix incorrect StatefulSet updateStrategy path in OnDelete example #53522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dominitas wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect StatefulSet updateStrategy path in OnDelete example #53522

dominitas wants to merge 1 commit into from
+1 −1

Conversation

@dominitas
Copy link

@dominitas dominitas commented Dec 6, 2025

The documentation used the field .spec.template.updateStrategy.type in the
StatefulSet OnDelete update strategy example. This field does not exist for
StatefulSets.

For StatefulSets, the correct field is:

.spec.updateStrategy.type

This PR updates the example to use the correct API path.

What was wrong

  • .spec.template.updateStrategy.type (incorrect)

Fix

  • .spec.updateStrategy.type (correct)

Why
The StatefulSet API defines updateStrategy at the StatefulSet spec level, not
inside the Pod template.

Reference:
https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/stateful-set-v1/

@dominitas
Fix incorrect StatefulSet updateStrategy path in OnDelete example
b5c8356 
The docs incorrectly used `.spec.template.updateStrategy.type`. 
The correct path for StatefulSet is `.spec.updateStrategy.type`.
Updated the example accordingly.
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign urvashi0109 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from kow3ns December 6, 2025 16:41
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 6, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 6, 2025 •
edited
Loading

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: dominitas / name: Domantas (b5c8356)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 6, 2025

Welcome @dominitas!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2025
@netlify
Copy link

netlify bot commented Dec 6, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b5c8356
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/69345c9d763ecf00088f3ad1
😎 Deploy Preview https://deploy-preview-53522--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dipesh-rawat
Copy link
Member

dipesh-rawat commented Dec 6, 2025

@dominitas Thanks you for your contribution.
Could you please sign the CLA before the PR can be reviewed.
You can follow the steps documented here: CLA Steps

dipesh-rawat
dipesh-rawat reviewed Dec 6, 2025
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

(To re-trigger the EasyCLA bot)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kow3ns kow3ns Awaiting requested review from kow3ns

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

1 more reviewer

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dominitas @k8s-ci-robot @dipesh-rawat