assertNotNull not working with set -e

[lwinkler]

It seems that shunit2 does not work with the -e flag of bash in some cases (but works fine in other). In particular assertNotNull raises an error (no matter if the assert fails or not). I don't know if the -e flag of bash is compatible with shunit2 but I use it to be sure to catch all errors.

set -e : Exit immediately if a command exits with a non-zero status.

Observed with bash 5.1.16. Here is a simple script to reproduce the bug:

set -e

testSomething() {

  # this behaves correctly
  assertNotSame "Not same" "aaa" "bbb"

  # this fails with message: ASSERT:Unknown failure encountered running a test
  assertNotNull "Not null(1)" "something"
}

source shunit2

[williamdes]

What is your version of shunit2?

[larssb]

I see the same when assertSame is used. I downloaded shUnit2 the 7th of February last year ( 2023 ). So the fix in #141 is there.

When

set -eo pipefail
shopt -s inherit_errexit

is active ... I get: ASSERT:unknown failure encountered running a test

Commenting them out:

#set -eo pipefail
#shopt -s inherit_errexit

And I get:

ASSERT:The returned base worker name should be the same as: test-test-worker expected:<ASS> but was:<test-test-worker>
shunit2:ERROR testReturnsCorrectBaseWorkerName() returned non-zero return code.

---

Further debugging showed that when using set without -e then I get no ASSERT:unknown failure encountered running a test error.

[puer-robustus]

This behavior is not limited to assertSame or assertNotNull.

I can produce the same error for assertFalse on shunit 2.1.8 in dash 0.5.12 with the following script:

#! /bin/sh

set -e

oneTimeSetUp() {
    echo "$SHUNIT_VERSION"
}

testFalse() {
  false
  assertFalse "" $?
}

# Load shUnit2.
. shunit2

Making this script executable and running it gives me the following:

2.1.8
testFalse
ASSERT:unknown failure encountered running a test

Ran 1 test.

FAILED (failures=1)

I wasn't able to make much out of the info from the shell with -ex but pasting it here nonetheless:

[...]
+ setUp
+ command [ 0 -eq 0 ]
+ echo testFalse
testFalse
+ eval testFalse
+ testFalse
+ false
+ _shunit_cleanup EXIT
+ _shunit_name_=EXIT
+ command [ EXIT != EXIT ]
+ command [ 1 -eq 1 ]
+ __shunit_clean=0
+ tearDown
+ command [ 0 -eq 0 ]
+ oneTimeTearDown
+ command [ 0 -eq 0 ]
+ command rm -fr /tmp/shunit.VkIG0f
+ command [ EXIT != EXIT ]
+ command [ 1 -eq 1 ]
+ _shunit_assertFail unknown failure encountered running a test
+ __shunit_testSuccess=1
+ _shunit_incFailedCount
+ expr 0 + 1
+ __shunit_assertsFailed=1
+ expr 0 + 1
+ __shunit_assertsTotal=1
+ [ 1 -gt 0 ]
+ echo ASSERT:unknown failure encountered running a test
[...]

Without the -e option the test passes just fine:

2.1.8
testFalse

Ran 1 test.

OK