Follow-up on optional feedback from @wjones127's review of #7743.
Two related suggestions from the review, both in python/src/blob.rs:
-
Add BinaryView support. Would love to support BinaryView in addition to Binary/LargeBinary.
-
Extract via an iterator instead of offset-specific code. Rather than writing code specific to the offset-based binary arrays (Binary and LargeBinary), add a function that extracts an iterator — like the existing pattern for strings in rust/lance-arrow/src/lib.rs#L470-L476. Then adding BinaryView support becomes trivial.
Good first issue: add an iterator-based binary extraction helper (mirroring the string helper), refactor the blob writer to use it, and extend it to cover BinaryView.
Follow-up on optional feedback from @wjones127's review of #7743.
Two related suggestions from the review, both in
python/src/blob.rs:Add
BinaryViewsupport. Would love to supportBinaryViewin addition toBinary/LargeBinary.Extract via an iterator instead of offset-specific code. Rather than writing code specific to the offset-based binary arrays (
BinaryandLargeBinary), add a function that extracts an iterator — like the existing pattern for strings inrust/lance-arrow/src/lib.rs#L470-L476. Then addingBinaryViewsupport becomes trivial.Good first issue: add an iterator-based binary extraction helper (mirroring the string helper), refactor the blob writer to use it, and extend it to cover
BinaryView.