fix(index): compare Hamming IVF centroids during merge - #8132
Merged
Xuanwo merged 1 commit intoAug 1, 2026
Conversation
github-actions
Bot
added
A-index
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Gate recommendation: approve. The base path rejects all multi-shard Hamming merges because the shared centroid comparator handles only floating-point tensors. Exact UInt8 equality at that shared invariant restores valid merges while continuing to reject incompatible shapes, types, and bytes, without changing floating-point tolerance behavior.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
justinrmiller
approved these changes
Aug 1, 2026
justinrmiller
left a comment
justinrmiller
left a comment
Contributor
There was a problem hiding this comment.
Might consider a generic fallback but lgtm
Xuanwo
approved these changes
Aug 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UInt8IVF centroid tensors exactly during distributed index merges