Skip to content

Commit 1226a6d

Browse files
authored
[clang-tidy] Fix fragile test in read-parameters-from-file (#171033)
[CommandLine.cpp](https://github.com/llvm/llvm-project/blob/fb0400fe1f1f9e83f3148db8ce2c72ab5bc6728e/llvm/lib/Support/CommandLine.cpp#L940) treats single quote as literal characters on Windows, so the argument is parsed as a check named `' -*,llvm-namespace-comment '`, which matches no existing checks, so no checks are enabled via the command line. Previously, the test passed because it fell back to the root `.clang-tidy` configuration which enables `llvm-*`.
1 parent 73a1383 commit 1226a6d

File tree

1 file changed

+1
-1
lines changed
  • clang-tools-extra/test/clang-tidy/infrastructure/Inputs/param

1 file changed

+1
-1
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
-checks='-*,llvm-namespace-comment'
1+
-checks=-*,llvm-namespace-comment
22
--warnings-as-errors=llvm-namespace-comment

0 commit comments

Comments
 (0)