list is not constexpr until C++26, thus not testable in C++23

Author: anonymouspc

libcxx/test/libcxx/ranges/range.adaptors/range.chunk/range.chunk.view/end.nodiscard.verify.cpp

@@ -21,6 +21,6 @@ void test() {
 
   // clang-format off
   view.end(); // expected-warning {{ignoring return value of function declared with 'nodiscard' attribute}}
-  td::as_const(view).end(); // expected-warning {{ignoring return value of function declared with 'nodiscard' attribute}}
+  std::as_const(view).end(); // expected-warning {{ignoring return value of function declared with 'nodiscard' attribute}}
   // clang-format on
 }

libcxx/test/std/ranges/range.adaptors/range.chunk/begin.pass.cpp

@@ -14,41 +14,41 @@
 
 #include <algorithm>
 #include <cassert>
-#include <list>
+#include <vector>
 
 #include "test_range.h"
 
 constexpr bool test() {
-  std::list<int> full_list  = {1, 1, 1, 2, 2, 2, 3, 3};
-  std::list<int> empty_list = {};
+  std::vector<int> full_vector  = {1, 1, 1, 2, 2, 2, 3, 3};
+  std::vector<int> empty_vector = {};
 
   // Test `chunk_view.begin()`
   {
-    auto view = full_list | std::views::chunk(3);
+    auto view = full_vector | std::views::chunk(3);
     auto it   = view.begin();
-    assert(std::ranges::equal(*it, std::list{1, 1, 1}));
-    assert(std::ranges::equal(*++it, std::list{2, 2, 2}));
-    assert(std::ranges::equal(*++it, std::list{3, 3})); // The last chunk has only 2 elements.
+    assert(std::ranges::equal(*it, std::vector{1, 1, 1}));
+    assert(std::ranges::equal(*++it, std::vector{2, 2, 2}));
+    assert(std::ranges::equal(*++it, std::vector{3, 3})); // The last chunk has only 2 elements.
     assert(++it == view.end());                         // Reaches end.
 
-    view = full_list | std::views::chunk(5);
+    view = full_vector | std::views::chunk(5);
     it   = view.begin();
-    assert(std::ranges::equal(*it, std::list{1, 1, 1, 2, 2}));
-    assert(std::ranges::equal(*++it, std::list{2, 3, 3}));
+    assert(std::ranges::equal(*it, std::vector{1, 1, 1, 2, 2}));
+    assert(std::ranges::equal(*++it, std::vector{2, 3, 3}));
   }
 
   // Test `empty_chunk_view.begin()`
   {
-    auto view = empty_list | std::views::chunk(3);
+    auto view = empty_vector | std::views::chunk(3);
     assert(view.size() == 0);
     assert(view.begin() == view.end());
   }
 
   // Test `small_view_with_big_chunk.begin()`
   {
-    auto view = full_list | std::views::chunk(314159);
+    auto view = full_vector | std::views::chunk(314159);
     assert(view.size() == 1);
-    assert(std::ranges::equal(*view.begin(), full_list));
+    assert(std::ranges::equal(*view.begin(), full_vector));
     assert(++view.begin() == view.end());
   }
 

libcxx/test/std/ranges/range.adaptors/range.chunk/end.pass.cpp

@@ -15,41 +15,36 @@
 #include <algorithm>
 #include <cassert>
 #include <concepts>
-#include <forward_list>
-#include <list>
+#include <vector>
 
 #include "test_range.h"
 #include "types.h"
 
 constexpr bool test() {
-  std::list list                 = {1, 1, 1, 2, 2, 2, 3, 3};
-  std::forward_list forward_list = {1, 1, 1, 2, 2, 2, 3, 3};
+  std::vector vector = {1, 1, 1, 2, 2, 2, 3, 3};
 
   // Test `chunk_view.end()`
   {
-    auto view = list | std::views::chunk(3);
+    auto view = vector | std::views::chunk(3);
     auto it   = view.end();
-    assert(std::ranges::equal(*--it, std::list{3, 3})); // We can adjust the tailing chunk-size.
-    assert(std::ranges::equal(*--it, std::list{2, 2, 2}));
-    assert(std::ranges::equal(*--it, std::list{1, 1, 1}));
+    assert(std::ranges::equal(*--it, std::vector{3, 3})); // We can adjust the tailing chunk-size.
+    assert(std::ranges::equal(*--it, std::vector{2, 2, 2}));
+    assert(std::ranges::equal(*--it, std::vector{1, 1, 1}));
   }
 
   // Test `not_sized_chunk_view.end()`
   {
-    auto not_sized_list = not_sized_view(list | std::views::all);
-    auto view           = not_sized_list | std::views::chunk(4);
+    auto not_sized_vector = not_sized_view(vector | std::views::all);
+    auto view             = not_sized_vector | std::views::chunk(4);
     static_assert(std::ranges::bidirectional_range<decltype(view)>);
     static_assert(!std::ranges::sized_range<decltype(view)>);
-    static_assert(
-        std::same_as<
-            decltype(view.end()),
-            std::
-                default_sentinel_t>); // We cannot handle the tailing chunk without size info, so we forbids one to derement from end().
+    // We cannot handle the tailing chunk without size info, so we forbids one to derement from end().
+    static_assert(std::same_as< decltype(view.end()), std::default_sentinel_t>);
   }
 
   // Test `forward_chunk_view.end()`
   {
-    auto view = list | std::views::chunk(5);
+    auto view = vector | std::views::chunk(5);
     assert(++(++view.begin()) == view.end());
   }