chore: improve code clarity

Author: loilo

src/parsers/array-slice-selector.php

@@ -10,7 +10,6 @@
 function apply_slice_selector($selector, $json)
 {
 	if (!is_json_array($json)) {
-		// throw new Error(`JSON node ${JSON.stringify(json)} is not an array`);
 		return [];
 	}
 

src/parsers/root.php

@@ -42,6 +42,7 @@ function apply_segment($segment, $root_node, $json)
 			return apply_selector($selector, $root_node, $json);
 		}, $segment);
 		$segment_result = array_flatten($selector_results);
+
 		return $segment_result;
 	}
 
@@ -104,23 +105,19 @@ function apply_member_name_selector($selector, $json)
 	if (json_object_has_key($json, $selector->member)) {
 		return [json_get($json, $selector->member)];
 	}
+
 	return [];
 }
 
 // 2.3.3. Index Selector
 // An index selector <index> matches at most one array element value.
 function apply_index_selector($node, $json)
 {
-	if (is_json_array($json)) {
-		if ($node->index < sizeof($json)) {
-			$index = normalize_index($node->index, sizeof($json));
-			if ($index === null) {
-				return [];
-			} else {
-				return [$json[$index]];
-			}
-		}
+	if (!is_json_array($json)) {
 		return [];
 	}
-	return [];
+
+	$index = normalize_index($node->index, sizeof($json));
+
+	return $index === null ? [] : [$json[$index]];
 }

src/utils/traverse-descendant.php

@@ -4,18 +4,18 @@
 
 function traverse_descendant($json)
 {
-	$nodelist = [];
-	array_push($nodelist, $json);
+	$node_list = [];
+	array_push($node_list, $json);
 
 	if (is_json_array($json)) {
 		foreach ($json as $node) {
-			array_push($nodelist, ...traverse_descendant($node));
+			array_push($node_list, ...traverse_descendant($node));
 		}
 	} elseif (is_json_object($json)) {
 		foreach ((array) $json as $value) {
-			array_push($nodelist, ...traverse_descendant($value));
+			array_push($node_list, ...traverse_descendant($value));
 		}
 	}
 
-	return $nodelist;
+	return $node_list;
 }