You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#4219 fixes the immediate cause of the v0.37.0 testnet release failure, but nothing would have caught it on the PR that introduced it.
To be fair to #4213: it wasn't malformed. reqwest = "0" already existed — #4213 just became the first crate to want reqwest 0.13 alongside Solana's 0.12, which gave cargo update --workspace something to rebind onto. The breakage then sat dormant until release time, a week later.
Proposal — run the guard on every PR:
Dry-run the release bump in PR CI. Run scripts/release/bump-version.sh against a throwaway version, assert the Cargo.lock diff is only member version lines, discard the result. This is the check that would actually have failed ip-verifier: add the IP ownership verification service #4213, because it exercises the same re-resolution path the release does.
#4219 fixes the immediate cause of the v0.37.0 testnet release failure, but nothing would have caught it on the PR that introduced it.
To be fair to #4213: it wasn't malformed.
reqwest = "0"already existed — #4213 just became the first crate to want reqwest 0.13 alongside Solana's 0.12, which gavecargo update --workspacesomething to rebind onto. The breakage then sat dormant until release time, a week later.Proposal — run the guard on every PR:
scripts/release/bump-version.shagainst a throwaway version, assert theCargo.lockdiff is only member version lines, discard the result. This is the check that would actually have failed ip-verifier: add the IP ownership verification service #4213, because it exercises the same re-resolution path the release does.[workspace.dependencies]for bare"0"requirements. Cheap, but only stops new instances of the declaration pattern, and needs the remaining 27 pinned first (see the audit in deps: pin reqwest and tokio-util to their locked 0.x minors #4219).(1) is the one worth having.