Unable to deploy modules if XCC port is secured with TLS

[mwarnes]

RFE

Roxy is unable to deploy modules if he XCC port is secure using TLS

Within ./deploy/lib/xcc.rb the url is hardcoded to use http.

  def build_load_uri(target_uri, options, commit)
  url = "http://#{@hostname}:#{@port}/insert?"

It would be useful if the url was created with the protocol set to http our https depending on a configuration setting such as in ./deploy/lib/ml_rest.rb, i.e

 @rest_protocol = "http#{options[:use_https_for_rest] ? 's' : ''}"
 ...
 url = "#{@rest_protocol}://#{@hostname}:#{@port}/v1/config/properties"

The issue can be worked round by hardcoding https in the xcc.rb url.

[grtjn]

I'm surprised this hasn't surfaced before yet. Shouldn't be too difficult to implement. Would you be willing to fork the project, and open a PR? You can find guidelines in CONTRIBUTING.md..

[heelix]

Do you know if this one was merged in? We are trying to add in a few SSL xcc ports to our app via ROXY (rather than tweak by hand). I can pick up this ball if it did not go anywhere.

[grtjn]

I don't think anyone looked into this yet, so feel free to open a PR!

[heelix]

Will do. Planning to get Roxy current in our environment as soon as 9.0-4.2 hits the downloads. Will be testing on that.