Skip to content

Fix Node deploy include dist folder and correct Oryx manifest #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mengyimicro merged 1 commit into from
Dec 5, 2025
Merged

Fix Node deploy include dist folder and correct Oryx manifest #71

mengyimicro merged 1 commit into from
Dec 5, 2025
+206 −17

Conversation

@mengyimicro
Copy link
Contributor

@mengyimicro mengyimicro commented Dec 4, 2025

This PR fixes two issues in the Node.js deployment path of the A365 CLI:

  1. Built assets in dist/ were not being deployed
    Node projects that use start: "node dist/index.js" failed on Azure with:
    Error: Cannot find module '/home/site/wwwroot/dist/index.js'

because the dist folder was never copied into the publish output.

  1. Node Oryx manifest sometimes contained Python build commands
    Generated oryx-manifest.toml files for Node projects could contain a
    build-command like:
[build]
platform = "nodejs"
version = "18"
build-command = "pip install -r requirements.txt"

which is incorrect for Node and causes confusing / broken builds.

@mengyimicro mengyimicro requested a review from a team as a code owner December 4, 2025 22:03
Copilot AI review requested due to automatic review settings December 4, 2025 22:03
@mengyimicro mengyimicro requested a review from a team as a code owner December 4, 2025 22:03
Copilot finished reviewing on behalf of mengyimicro December 4, 2025 22:06
Copilot AI reviewed Dec 5, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

sellakumaran
sellakumaran reviewed Dec 5, 2025
View reviewed changes
sellakumaran
sellakumaran previously approved these changes Dec 5, 2025
View reviewed changes
@mengyimicro mengyimicro force-pushed the users/mengyixu/fixNodeDeployEntryPoint branch from 7242b1a to d0d2c99 Compare December 5, 2025 19:22
@mengyimicro mengyimicro merged commit 8acf918 into main Dec 5, 2025
5 checks passed
@mengyimicro mengyimicro deleted the users/mengyixu/fixNodeDeployEntryPoint branch December 5, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@tmlsousa tmlsousa tmlsousa approved these changes

@sellakumaran sellakumaran sellakumaran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mengyimicro @tmlsousa @sellakumaran