Tidy some internal headers too (#7464)

Author: achamayou

.clang-tidy

@@ -9,6 +9,7 @@ Checks: >
   -bugprone-casting-through-void,
   -bugprone-reserved-identifier,
   -bugprone-macro-parentheses,
+  -bugprone-branch-clone,
   cert-*,
   -cert-con36-c,
   -cert-dcl37-c,
@@ -58,5 +59,5 @@ Checks: >
   -readability-magic-numbers,
 
 WarningsAsErrors: '*'
-HeaderFilterRegex: 'include\/ccf\/.*'
+HeaderFilterRegex: '(include\/ccf\/|src\/(udp|tcp|tls|tasks|snapshots|service|quic|pal|apps|clients|common|consensus|ds)\/).*'
 FormatStyle:     'file'

js/ccf-app/src/endpoints.ts

@@ -158,14 +158,12 @@ interface UserMemberCOSEAuthIdentityCommon {
 }
 
 export interface MemberCOSESign1AuthnIdentity
-  extends UserMemberAuthnIdentityCommon,
-    UserMemberCOSEAuthIdentityCommon {
+  extends UserMemberAuthnIdentityCommon, UserMemberCOSEAuthIdentityCommon {
   policy: "member_cose_sign1";
 }
 
 export interface UserCOSESign1AuthnIdentity
-  extends UserMemberAuthnIdentityCommon,
-    UserMemberCOSEAuthIdentityCommon {
+  extends UserMemberAuthnIdentityCommon, UserMemberCOSEAuthIdentityCommon {
   policy: "user_cose_sign1";
 }
 

src/common/configuration.h

@@ -30,13 +30,13 @@ DECLARE_JSON_ENUM(
 
 struct EnclaveConfig
 {
-  uint8_t* to_enclave_buffer_start;
-  size_t to_enclave_buffer_size;
-  ringbuffer::Offsets* to_enclave_buffer_offsets;
+  uint8_t* to_enclave_buffer_start = nullptr;
+  size_t to_enclave_buffer_size = 0;
+  ringbuffer::Offsets* to_enclave_buffer_offsets = nullptr;
 
-  uint8_t* from_enclave_buffer_start;
-  size_t from_enclave_buffer_size;
-  ringbuffer::Offsets* from_enclave_buffer_offsets;
+  uint8_t* from_enclave_buffer_start = nullptr;
+  size_t from_enclave_buffer_size = 0;
+  ringbuffer::Offsets* from_enclave_buffer_offsets = nullptr;
 
   oversized::WriterConfig writer_config = {};
 };

src/common/enclave_interface_types.h

@@ -4,7 +4,7 @@
 
 #include "ccf/ds/logger_level.h"
 
-enum CreateNodeStatus
+enum CreateNodeStatus : std::uint8_t
 {
   /** Call was successful and the node was successfully created */
   OK = 0,
@@ -88,7 +88,7 @@ constexpr char const* create_node_result_to_str(CreateNodeStatus result)
   }
 }
 
-enum StartType
+enum StartType : std::uint8_t
 {
   Start = 1,
   Join = 2,

src/consensus/aft/impl/state.h

@@ -132,12 +132,12 @@ namespace aft
   class Replica
   {
   public:
-    Replica(const ccf::NodeId& id_, const std::vector<uint8_t>& cert_) :
-      id(id_),
+    Replica(ccf::NodeId id_, const std::vector<uint8_t>& cert_) :
+      id(std::move(id_)),
       verifier(ccf::crypto::make_unique_verifier(cert_))
     {}
 
-    ccf::NodeId get_id() const
+    [[nodiscard]] ccf::NodeId get_id() const
     {
       return id;
     }
@@ -149,8 +149,8 @@ namespace aft
 
   struct State
   {
-    State(const ccf::NodeId& node_id_, bool pre_vote_enabled_ = false) :
-      node_id(node_id_),
+    State(ccf::NodeId node_id_, bool pre_vote_enabled_ = false) :
+      node_id(std::move(node_id_)),
       pre_vote_enabled(pre_vote_enabled_)
     {}
     State() = default;