You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added regression coverage for the .NET tool-approval no-session fix by exercising Go's existing implicit-session behavior through a real agent run. The new tests verify that agent.prepareRun creates exactly one implicit session, threads it through tool-approval auto-approval re-entry, and still provides that session on a no-approval pass-through run.
No. This is a test-only parity update for behavior the Go SDK already implements.
Tests and Examples
go test ./agent/harness/toolapproval
Added focused tests for implicit session threading during tool-approval auto-approval re-entry and for single implicit-session creation when no approval request is returned
Notes
Go already aligned the runtime behavior before this change because agent.prepareRun injects an implicit session before middleware executes. This PR ports the upstream regression coverage so that alignment stays protected. Go uses a single streamed run path, so separate .NET non-streaming and streaming coverage collapses into these focused tests.
This was originally intended as a pull request, but GitHub Actions is not permitted to create or approve pull requests in this repository.
The changes have been pushed to branch copilot/dotnet-port-fixes-toolapproval-implicit-session-684c84d4411d22d8.
To fix the permissions issue, go to Settings → Actions → General and enable Allow GitHub Actions to create and approve pull requests. See also: gh-aw FAQ
Summary
Added regression coverage for the .NET tool-approval no-session fix by exercising Go's existing implicit-session behavior through a real agent run. The new tests verify that
agent.prepareRuncreates exactly one implicit session, threads it through tool-approval auto-approval re-entry, and still provides that session on a no-approval pass-through run.Ported .NET PRs
28e02d466997972d51c0a435b133a875f7444976(link)Breaking Changes
No. This is a test-only parity update for behavior the Go SDK already implements.
Tests and Examples
go test ./agent/harness/toolapprovalNotes
Go already aligned the runtime behavior before this change because
agent.prepareRuninjects an implicit session before middleware executes. This PR ports the upstream regression coverage so that alignment stays protected. Go uses a single streamed run path, so separate .NET non-streaming and streaming coverage collapses into these focused tests.Note
This was originally intended as a pull request, but GitHub Actions is not permitted to create or approve pull requests in this repository.
The changes have been pushed to branch
copilot/dotnet-port-fixes-toolapproval-implicit-session-684c84d4411d22d8.Click here to create the pull request
To fix the permissions issue, go to Settings → Actions → General and enable Allow GitHub Actions to create and approve pull requests. See also: gh-aw FAQ
Show patch preview (169 of 169 lines)