Skip to content

Unused Recommendations parameters: enableAHBRecommendations and enableSpotRecommendations are declared but never used #2095

@helderpinto

Description

@helderpinto

🐛 Problem

In the Recommendations app template, two parameters are declared but never used:

This causes Bicep linter warnings and can be confusing because the parameter descriptions imply behavior toggles that currently have no effect.

👣 Repro steps

  1. Open app.bicep
  2. Locate the two parameter declarations at:
  1. Run Bicep diagnostics/lint for the file
  2. Observe warnings with rule no-unused-params:
  • Parameter "enableAHBRecommendations" is declared but never used
  • Parameter "enableSpotRecommendations" is declared but never used

🤔 Expected

Either:

  • The parameters should be wired into the template behavior (for example, controlling which recommendation queries/rules are included), or
  • The parameters should be removed if this behavior is not currently supported
    In either case, the template should not emit no-unused-params warnings and should accurately reflect available functionality.

🔧 Environment

  • FinOps hub version: 14.0-dev

ℹ️ Additional context

The issue appears localized to:

Potential impact:

  • Noise in lint/CI pipelines
  • Misleading configuration surface for users who expect these toggles to change deployment behavior

🙋‍♀️ Ask for the community

We could use your help:

  1. Please vote this issue up (👍) to prioritize it.
  2. Leave comments to help us solidify the vision.

Metadata

Metadata

Labels

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions