From 5a96ffe97eb5a661a3101842382ac5c4d9530f01 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Amaury=20Lev=C3=A9?= Date: Tue, 26 May 2026 16:22:41 +0200 Subject: [PATCH] Simplify logging helper methods in JsonConfigurationProvider Replace verbose async methods with concise expression-bodied members using null-conditional operator for improved readability. - Reduced three 6-line methods to single-line expressions - Maintained identical functionality and async behavior - Improved code clarity without sacrificing explicitness Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../JsonConfigurationProvider.cs | 27 +++++-------------- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/src/Platform/Microsoft.Testing.Platform/Configurations/JsonConfigurationProvider.cs b/src/Platform/Microsoft.Testing.Platform/Configurations/JsonConfigurationProvider.cs index ae132584ba..8e0c73d2c9 100644 --- a/src/Platform/Microsoft.Testing.Platform/Configurations/JsonConfigurationProvider.cs +++ b/src/Platform/Microsoft.Testing.Platform/Configurations/JsonConfigurationProvider.cs @@ -26,29 +26,14 @@ internal sealed class JsonConfigurationProvider( public string? ConfigurationFile { get; private set; } - private async Task LogInformationAsync(string message) - { - if (_logger is not null) - { - await _logger.LogInformationAsync(message).ConfigureAwait(false); - } - } + private Task LogInformationAsync(string message) + => _logger?.LogInformationAsync(message) ?? Task.CompletedTask; - private async Task LogDebugAsync(string message) - { - if (_logger is not null) - { - await _logger.LogDebugAsync(message).ConfigureAwait(false); - } - } + private Task LogDebugAsync(string message) + => _logger?.LogDebugAsync(message) ?? Task.CompletedTask; - private async Task LogErrorAsync(string message, Exception exception) - { - if (_logger is not null) - { - await _logger.LogErrorAsync(message, exception).ConfigureAwait(false); - } - } + private Task LogErrorAsync(string message, Exception exception) + => _logger?.LogErrorAsync(message, exception) ?? Task.CompletedTask; public async Task LoadAsync() {