Error from `gh pr edit` leaves stack in semi-exported state

[maxwindiff]

Hello! I'm trying out stack-pr but I'm hitting a few issues:

1. Not sure why gh pr edit fails. I tried running it in the shell and it seems fine. There were no error messages.
2. It created a PR but didn't associate it with local commits, so I'm not sure how to recover from this state.

% STACKPR_CONFIG=/home/ubuntu/.stack-pr.cfg stack-pr view
VIEW
Stack:
   * 71d96dc2 (no PR, 'maxng/subgraph/5' -> 'maxng/subgraph/4'): <redacted>
   * 590fe21d (no PR, 'maxng/subgraph/4' -> 'maxng/subgraph/3'): <redacted>
   * feaa7453 (no PR, 'maxng/subgraph/3' -> 'maxng/subgraph/2'): <redacted>
   * dd9edf77 (no PR, 'maxng/subgraph/2' -> 'maxng/subgraph/1'): <redacted>
   * 0bfb6aae (no PR, 'maxng/subgraph/1' -> 'main'): <redacted>

This stack can't be landed yet, you need to export it first.

You can use the following command to do that:
  $ stack-pr export -B subgraph~5 -H subgraph

% STACKPR_CONFIG=/home/ubuntu/.stack-pr.cfg stack-pr export -B subgraph~5 -H subgraph~4
SUBMIT
Initializing local branches
Stack:
   * 0bfb6aae (no PR, 'maxng/subgraph/1' -> 'main'): <redacted>
Resetting remote base branches
Updating remote branches
Submitting PRs
Creating PR 'maxng/subgraph/1' -> 'main'
Created: https://<redacted>
Verifying stack info
Updating commit messages with stack metadata
Updating remote branches
Adding cross-links to PRs
Exitcode: 1
Stdout: None
Stderr: None
Traceback (most recent call last):
  File "/home/ubuntu/.local/bin/stack-pr", line 7, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/ubuntu/.local/share/pipx/venvs/stack-pr/lib/python3.12/site-packages/stack_pr/cli.py", line 1406, in main
    command_submit(
  File "/home/ubuntu/.local/share/pipx/venvs/stack-pr/lib/python3.12/site-packages/stack_pr/cli.py", line 950, in command_submit
    add_cross_links(st, keep_body, args.verbose)
  File "/home/ubuntu/.local/share/pipx/venvs/stack-pr/lib/python3.12/site-packages/stack_pr/cli.py", line 748, in add_cross_links
    run_shell_command(
  File "/home/ubuntu/.local/share/pipx/venvs/stack-pr/lib/python3.12/site-packages/stack_pr/shell_commands.py", line 40, in run_shell_command
    return subprocess.run(list(map(str, cmd)), **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['gh', 'pr', 'edit', 'https://<redacted>', '-t', '<redacted>', '-F', '-', '-B', 'main']' returned non-zero exit status 1.

[ssanderson]

I hit this same issue running on Ubuntu 24.04. My issue turned out to be that I was using the version of gh that is packaged by default on Ubuntu 24, which seems to be using deprecated API features. The output for me looked like:

Stderr: GraphQL: Projects (classic) is being deprecated in favor of the new Projects experience, see: https://github.blog/changelog/2024-05-23-sunset-notice-projects-classic/. (repository.pullRequest.projectCards)

Upgrading to the latest release of gh fixed the issue for me.