Use venv for pre-commit in CI instead of pip install

The CI creates a venv via python_venv setup step that has pre-commit
installed from requirements.txt. Activate this venv instead of trying
to install pre-commit via pip which creates PATH issues.

Author: nammn

.pre-commit-config.yaml

@@ -228,14 +228,8 @@ repos:
 
       - id: regenerate-multicluster-rbac
         name: Regenerate multi-cluster RBAC samples
-        entry: bash
-        args:
-          - -c
-          - |
-            cd pkg/kubectl-mongodb/common && \
-            EXPORT_RBAC_SAMPLES=true go test ./... -run TestPrintingOutRolesServiceAccountsAndRoleBindings && \
-            git add ../../../public/samples/multi-cluster-cli-gitops
-        language: system
+        entry: scripts/dev/regenerate_multicluster_rbac.sh
+        language: script
         files: ^(cmd/kubectl-mongodb|pkg/kubectl-mongodb)/
         pass_filenames: false
 

scripts/dev/regenerate_multicluster_rbac.sh

@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+set -Eeou pipefail
+
+# Source the environment context to get go in PATH
+# shellcheck disable=SC1091
+source scripts/dev/set_env_context.sh
+
+echo "Regenerating multi-cluster RBAC samples"
+cd pkg/kubectl-mongodb/common
+EXPORT_RBAC_SAMPLES=true go test ./... -run TestPrintingOutRolesServiceAccountsAndRoleBindings
+git add ../../../public/samples/multi-cluster-cli-gitops

scripts/evergreen/check_precommit.sh

@@ -6,16 +6,20 @@ initial_index_state=$(git diff --name-only --cached --diff-filter=AM)
 
 export EVERGREEN_MODE=true
 
-# Install pre-commit if not available
-if ! command -v pre-commit >/dev/null 2>&1; then
-  echo "Installing pre-commit..."
-  pip install pre-commit
-  # Add ~/.local/bin to PATH if it exists (pip installs scripts there)
-  if [[ -d "${HOME}/.local/bin" ]]; then
-    export PATH="${HOME}/.local/bin:${PATH}"
-  fi
+# Source the environment context (sets up PATH for go, etc.)
+# This is created by clone->setup_context step in CI
+# shellcheck disable=SC1091
+source scripts/dev/set_env_context.sh
+
+# Activate the venv if it exists (CI creates this via python_venv setup step)
+# The venv contains pre-commit installed from requirements.txt
+if [[ -f "${PROJECT_DIR}/venv/bin/activate" ]]; then
+  echo "Activating venv..."
+  # shellcheck disable=SC1091
+  source "${PROJECT_DIR}/venv/bin/activate"
 fi
 
+# pre-commit should now be available from the venv
 echo "Running pre-commit hooks..."
 echo "pre-commit version: $(pre-commit --version)"
 

scripts/evergreen/lint_code.sh

@@ -1,6 +1,10 @@
 #!/usr/bin/env bash
 set -Eeou pipefail
 
+# Source the environment context to get go in PATH
+# shellcheck disable=SC1091
+source scripts/dev/set_env_context.sh
+
 # Set required version
 required_version="v2.0.2"