Role seems to be login in secret

[halkeye]

Looking at https://github.com/movetokube/postgres-operator/blob/master/internal/controller/postgresuser_controller.go#L168 its setting ROLE to role which is what login is based on.

Does it make sense to set it to PostgresGroup? or have another variable for it?

LOGIN='jellystat-c3WD9F'
ROLE='jellystat-c3WD9F'

I only noticed because jellystat defaults the role to the login unless you override it, so i override it to ROLE, and i got an error about setting the table owner to 'jellystat-c3WD9F' not the 'jellystat-group'

[pcallewaert]

Hi 👋

This is some "legacy" of the Azure Single Server integration, where ROLE and LOGIN where different values. Today it doesn't make sense to have them both, but it would be a breaking change to remove one or the other.
I'm not sure if I understand your issue, you want to know the role name (of the owner group ?) in the secret?

[halkeye]

I'm not sure if I understand your issue, you want to know the role name (of the owner group ?) in the secret?

Yea I guess so? It's totally a nice to have. In the couple years of using this operator (thx btw) I've never needed it before but jellystat has some migrations that want the role name.

[spanktar]

We also need to get the role name in the secret for some migrations bits.

LOGIN: usecase-XADRzY
MASTER_ROLE: usecase_role

apiVersion: db.movetokube.com/v1alpha1
kind: Postgres
metadata:
  name: usecase-psql
  namespace: main
spec:
  database: sdi_usecase
  dropOnDelete: false
  masterRole: usecase_role
  schemas:
    - app
  # List of extensions that should be created in the database (optional)
  extensions:
    - pgcrypto
    - pg_stat_statements
---
apiVersion: db.movetokube.com/v1alpha1
kind: PostgresUser
metadata:
  name: usecase-user
  namespace: main
spec:
  role: usecase
  database: usecase-psql # This references the Postgres CR above
  secretName: db-psql-usecase-creds
  privileges: OWNER