Skip to content

Conversation

@kik-kik
Copy link
Contributor

@kik-kik kik-kik commented Dec 3, 2025

feat: add back scheduling settings for firefox_ios_derived/app_store_choice_screen_selection_v1

Apple confirmed a 7 day window is expected for this report.

@kik-kik kik-kik self-assigned this Dec 3, 2025
@kik-kik kik-kik requested a review from a team December 3, 2025 11:54
@kik-kik kik-kik added the enhancement New feature or request label Dec 3, 2025
@dataops-ci-bot
Copy link

Integration report for "feat: add back scheduling settings for firefox_ios_derived/app_store_choice_screen_selection_v1"

sql.diff

Click to expand!
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/dags/bqetl_firefox_ios.py /tmp/workspace/generated-sql/dags/bqetl_firefox_ios.py
--- /tmp/workspace/main-generated-sql/dags/bqetl_firefox_ios.py	2025-12-03 11:59:37.000000000 +0000
+++ /tmp/workspace/generated-sql/dags/bqetl_firefox_ios.py	2025-12-03 12:01:37.000000000 +0000
@@ -46,6 +46,24 @@
     secret="airflow-gke-secrets",
     key="bqetl_firefox_ios__app_store_connect_key",
 )
+firefox_ios_derived__app_store_choice_screen_selection__v1_bqetl_firefox_ios__app_store_connect_issuer_id = Secret(
+    deploy_type="env",
+    deploy_target="CONNECT_ISSUER_ID",
+    secret="airflow-gke-secrets",
+    key="bqetl_firefox_ios__app_store_connect_issuer_id",
+)
+firefox_ios_derived__app_store_choice_screen_selection__v1_bqetl_firefox_ios__app_store_connect_key_id = Secret(
+    deploy_type="env",
+    deploy_target="CONNECT_KEY_ID",
+    secret="airflow-gke-secrets",
+    key="bqetl_firefox_ios__app_store_connect_key_id",
+)
+firefox_ios_derived__app_store_choice_screen_selection__v1_bqetl_firefox_ios__app_store_connect_key = Secret(
+    deploy_type="env",
+    deploy_target="CONNECT_KEY",
+    secret="airflow-gke-secrets",
+    key="bqetl_firefox_ios__app_store_connect_key",
+)
 
 
 default_args = {
@@ -373,6 +391,30 @@
         ],
     )
 
+    firefox_ios_derived__app_store_choice_screen_selection__v1 = GKEPodOperator(
+        task_id="firefox_ios_derived__app_store_choice_screen_selection__v1",
+        arguments=[
+            "python",
+            "sql/moz-fx-data-shared-prod/firefox_ios_derived/app_store_choice_screen_selection_v1/query.py",
+        ]
+        + [
+            "--date={{macros.ds_add(ds, -7)}}",
+            "--connect_app_id=989804926",
+            "--partition_field=logical_date",
+        ],
+        image="gcr.io/moz-fx-data-airflow-prod-88e0/bigquery-etl:latest",
+        owner="[email protected]",
+        email=["[email protected]", "[email protected]", "[email protected]"],
+        secrets=[
+            firefox_ios_derived__app_store_choice_screen_selection__v1_bqetl_firefox_ios__app_store_connect_issuer_id,
+            firefox_ios_derived__app_store_choice_screen_selection__v1_bqetl_firefox_ios__app_store_connect_key_id,
+            firefox_ios_derived__app_store_choice_screen_selection__v1_bqetl_firefox_ios__app_store_connect_key,
+        ],
+        retry_delay=datetime.timedelta(seconds=1800),
+        retries=2,
+        email_on_retry=False,
+    )
+
     firefox_ios_derived__app_store_funnel__v1 = bigquery_etl_query(
         task_id="firefox_ios_derived__app_store_funnel__v1",
         destination_table="app_store_funnel_v1",
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_ios_derived/app_store_choice_screen_selection_v1/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_ios_derived/app_store_choice_screen_selection_v1/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/firefox_ios_derived/app_store_choice_screen_selection_v1/metadata.yaml	2025-12-03 11:56:16.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/firefox_ios_derived/app_store_choice_screen_selection_v1/metadata.yaml	2025-12-03 11:56:18.000000000 +0000
@@ -1,7 +1,8 @@
 friendly_name: Apple App Store Choice Screen Selection (post-iOS 18.2 only)
 description: "Apple App Store Choice Screen Engagement (post-iOS 18.2 only)\nThis\
   \ report includes rates around user selection/egagement with our browser\nvia the\
-  \ App Store Choice Screen.\n\nOfficial docs: https://developer.apple.com/documentation/analytics-reports/browser-choice-screen-selection\n\
+  \ App Store Choice Screen. We expect this report to be generated with a 7 day lag.\n\
+  \nOfficial docs: https://developer.apple.com/documentation/analytics-reports/browser-choice-screen-selection\n\
   \nNote: Starting 2025-06-23 Apple changed the value of the \"territory\" field\n\
   \      from the user\u2019s region code as set in \"Language & Region\" to the user's\
   \ App Store storefront region.\n"
@@ -11,7 +12,26 @@
   schedule: daily
   incremental: true
   table_type: aggregate
+  dag: bqetl_firefox_ios
   owner1: kik
+scheduling:
+  dag_name: bqetl_firefox_ios
+  depends_on_past: false
+  arguments:
+  - --date={{macros.ds_add(ds, -7)}}
+  - --connect_app_id=989804926
+  - --partition_field=logical_date
+  secrets:
+  - deploy_target: CONNECT_ISSUER_ID
+    key: bqetl_firefox_ios__app_store_connect_issuer_id
+  - deploy_target: CONNECT_KEY_ID
+    key: bqetl_firefox_ios__app_store_connect_key_id
+  - deploy_target: CONNECT_KEY
+    key: bqetl_firefox_ios__app_store_connect_key
+  date_partition_offset: -7
+  retry_delay: 30m
+  retries: 2
+  email_on_retry: false
 bigquery:
   time_partitioning:
     type: day

Link to full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants