From 017ea851cc473b5f77afe00d976f18442219b015 Mon Sep 17 00:00:00 2001 From: Frida Kiriakos Date: Tue, 21 Oct 2025 16:51:10 +0200 Subject: [PATCH 1/2] use env to pass input and output parameters --- .github/workflows/l10n.yml | 4 +++- .github/workflows/smoke.yml | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/l10n.yml b/.github/workflows/l10n.yml index 4bd458c1a..528002192 100644 --- a/.github/workflows/l10n.yml +++ b/.github/workflows/l10n.yml @@ -206,8 +206,10 @@ jobs: shell: pwsh - name: Download Executable if: ${{ inputs.win_installer_link }} + env: + WIN_INSTALLER_LINK: ${{ inputs.win_installer_link }} run: | - Invoke-WebRequest -Uri ${{ inputs.win_installer_link }} -OutFile "${{ github.workspace }}\setup.exe" + Invoke-WebRequest -Uri $WIN_INSTALLER_LINK -OutFile "${{ github.workspace }}\setup.exe" New-Item -ItemType Directory -Path "C:\Program Files\Custom Firefox" -Force shell: pwsh - name: Install Beta diff --git a/.github/workflows/smoke.yml b/.github/workflows/smoke.yml index 7a3d15bb3..432e53a71 100644 --- a/.github/workflows/smoke.yml +++ b/.github/workflows/smoke.yml @@ -91,8 +91,10 @@ jobs: shell: pwsh - name: Download Executable if: ${{ inputs.win_installer_link }} + env: + WIN_INSTALLER_LINK: ${{ inputs.win_installer_link }} run: | - Invoke-WebRequest -Uri ${{ inputs.win_installer_link }} -OutFile "${{ github.workspace }}\setup.exe" + Invoke-WebRequest -Uri $WIN_INSTALLER_LINK -OutFile "${{ github.workspace }}\setup.exe" New-Item -ItemType Directory -Path "C:\Program Files\Custom Firefox" -Force shell: pwsh - name: Install Beta From 9d90c52c326846c25178382c6742b93ceaf6ad4d Mon Sep 17 00:00:00 2001 From: Frida Kiriakos Date: Tue, 9 Dec 2025 14:08:54 +0300 Subject: [PATCH 2/2] pass test_set input parameter in the env parameters --- .github/workflows/main.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 30101fa6f..93a9899d8 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -38,6 +38,7 @@ on: type: string env: FX_CHANNEL: ${{ inputs.channel }} + TEST_SET: ${{ inputs.test_set }} TESTRAIL_BASE_URL: ${{ secrets.TESTRAIL_BASE_URL }} TESTRAIL_API_KEY: ${{ secrets.TESTRAIL_API_KEY }} TESTRAIL_USERNAME: ${{ secrets.TESTRAIL_USERNAME }} @@ -67,12 +68,12 @@ jobs: - name: Select Test Set if: ${{ inputs.test_set != null }} run: | - echo "STARFOX_SPLIT=${{ inputs.test_set }}" | Out-File -FilePath .env -Encoding utf8 -Append -Force + echo "STARFOX_SPLIT=$TEST_SET" | Out-File -FilePath .env -Encoding utf8 -Append -Force shell: pwsh - name: Set Functional Split if: ${{ inputs.test_set == 'functional' }} run: | - echo "STARFOX_SPLIT=${{ inputs.test_set }}1" | Out-File -FilePath .env -Encoding utf8 -Append -Force + echo "STARFOX_SPLIT=$TEST_SET1" | Out-File -FilePath .env -Encoding utf8 -Append -Force - name: Install dependencies run: | mkdir -p artifacts; @@ -173,10 +174,10 @@ jobs: echo "Running report for most recent Beta on MacOS"; - name: Select Test Set if: ${{ inputs.test_set != null }} - run: echo "STARFOX_SPLIT=${{ inputs.test_set }}" >> .env + run: echo "STARFOX_SPLIT=$TEST_SET" >> .env - name: Set Functional Split if: ${{ inputs.test_set == 'functional' }} - run: echo "STARFOX_SPLIT=${{ inputs.test_set }}1" >> .env + run: echo "STARFOX_SPLIT=$TEST_SET1" >> .env - name: Set Environment (Manual) if: ${{ inputs.mac_installer_link }} run: |