Migrate to vue 3 and nextcloud/vue 9#28
Merged
Merged
Conversation
julien-nc
commented
Jun 24, 2025
julien-nc
commented
Member
- Stick with webpack
- Fix new constraint on NcActions (only accept NcAction* in default slot)
- Fix style issues because Vue 3 does not replace the mount point but appends stuff in it
- Fix assistant menu entry height
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
andrey18106
approved these changes
Jun 24, 2025
andrey18106
left a comment
andrey18106
left a comment
Contributor
There was a problem hiding this comment.
A few ::v-deep -> :deep() migrations is missing (warnings). Apart from that LGTM.
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.