Integrate the the Mail Quota with the User Files Quota and provide a combined value

[miaulalala]

Is your feature request related to a problem? Please describe.

So - Files Quota would be for example 5GB - Mail Server provides Quota of 2GB and has 1GB used - so show 5 GB with separate colour or marker for 2GB mail quota and 1GB taken from Mail, and whatever is taken from Files.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

[ChristophWurst]

What's the goal?

[miaulalala]

What's the goal?

To make users sort out their mails 😉

[the-djmaze]

What's the goal?

To make users sort out their mails 😉

Which emails?
If you added more accounts, how do you know which emails to delete in the combined inbox view?

[miaulalala]

What's the goal?

To make users sort out their mails 😉

Which emails? If you added more accounts, how do you know which emails to delete in the combined inbox view?

The idea was to make users aware of how much space they take up, and have their File Quota be reduced by the size of their mailbox to sort of "pressure" users into actually deleting emails from the server.

[kesselb]

I followed up with Anna regarding this feature request.

The idea was suggested during company week, where the concept of a "combined" quota for files and mail was proposed.

I can see how this makes sense from a service provider's perspective, and it’s a great enhancement. However, I believe we should only "report" the quota for provisioned accounts, as it feels a bit off to include external accounts in this calculation.

To implement this feature for mail, we first need to lay the groundwork on the server. Currently, there’s no way to "signal" a quota (with both value and type) back to the server; we can only overwrite it.

Related: nextcloud/server#44391.

[madbob]

I'm not persuaded nextcloud/server#44391 is somehow related to this, as it is about type of contents in Files.

I've submitted a PR to Server to apply a different approach: delegate Quota handling to third party apps. This would permit implementing a variety of different edge use cases, including the one here mentioned (the total "used quota" is the sum of Files size and Mail size), without mess up with core applications.

Comments (and thumbs up ;-) ) to the PR are welcome.

[kesselb]

I've submitted nextcloud/server#63230 to apply a different approach: delegate Quota handling to third party apps.

That approach might work some cases, but I don't see it as solution for this. The current code is bound to the filesystem. Registering a storage wrapper in Mail to signal the quota (which in the majority of the cases does not event count to the actual user's storage) seems wrong.

If we want a quota / storage overview like Google or iCloud, server must provide an api for apps to signal their storage / quota usages. Probably by adding another abstraction layer in between.

Sample from Google:

[madbob]

Registering a storage wrapper in Mail

The idea was not to implement this into Mail, but delegate to some app implementing the exact conditions required by the user.

Given the proposed change in Server: throw this totally untested (and totally broken, I have just realized, but you got the idea ;-) ) code in the apps folder

use OC\Files\Filesystem;
use OC\Files\Storage\Wrapper\Quota;
use OCA\Mail\Contracts\IMailManager;
use OCA\Mail\Service\AccountService;
use OCP\Files\Storage\IStorage;
use OCP\IUserSession;
use OCP\Server;

class CustomQuota extends Quota {
	public function __construct(
		private IMailManager $mailManager,
		private AccountService $accountService,
	){
	}

	public function getQuota(): int|float {
		/*
			Can be a manual setting provided in a configuration file, in the UI, 
			or an hard-wired value. Flat, or calculated on top of mail quota 
			provided by $this->mailManager
		*/
		return 10 * 1024 * 1024 * 1024;
	}

	protected function getSize(string $path, ?IStorage $storage = null): int|float {
		/*
			Sum mail usage + filesystem usage.
			Some caching can be required ;-)
		*/

		$session = Server::get(IUserSession::class);
		$userId = $session->getUser()->getUID();

		$mailUsage = 0;
		$accounts = $accountService->findByUserId($userId);
		foreach($accounts as $account) {
			/*
				Maybe provisioned accounts should be filtered.
				Or maybe not.
			*/
			$mailUsage += $this->mailManager->getQuota($account)->getUsage();
		}

		$cache = is_null($storage) ? $this->getCache() : $storage->getCache();
		$data = $cache->get('/');
		$filesUsage = $data['size'];

		return $filesUsage + $mailUsage;
	}

	public function free_space(string $path): int|float|false {
		return $this->getQuota() - $this->getSize('/');
	}
}

then register a listener for BeforeFileSystemSetupEvent, add this storage wrapper under the "Quota" name, and a majority of service providers are covered.

But there are many use cases (combined quota files + mail, per user or per organization, considering this but not that mail account...) and even more edge cases. Covering all of them in the core Nextcloud would require an infinite amount of effort. Delegating this to third parties (including: service providers able to write their own 50 lines of code with custom logics) can sensibly speed up things, and yet permit Nextcloud to offer one day a supported app covering what is considered interesting.

Give them a fishing rod.