fix(utils): correct byte formatting boundaries for rounding

Author: watilde

lib/utils/format-bytes.js

@@ -13,12 +13,12 @@ const formatBytes = (bytes, space = true) => {
     return `${bytes}${spacer}B`
   }
 
-  if (bytes < 1000000) {
+  if (bytes < 999950) {
     // kB
     return `${(bytes / 1000).toFixed(1)}${spacer}kB`
   }
 
-  if (bytes < 1000000000) {
+  if (bytes < 999950000) {
     // MB
     return `${(bytes / 1000000).toFixed(1)}${spacer}MB`
   }

test/lib/utils/format-bytes.js

@@ -0,0 +1,25 @@
+const t = require('tap')
+const formatBytes = require('../../../lib/utils/format-bytes.js')
+
+t.test('formatBytes', (t) => {
+  t.equal(formatBytes(0), '0 B', '0 bytes')
+  t.equal(formatBytes(1), '1 B', '1 byte')
+  t.equal(formatBytes(10), '10 B', '10 bytes')
+  t.equal(formatBytes(999), '999 B', '999 bytes')
+  t.equal(formatBytes(1000), '1.0 kB', '1000 bytes')
+  t.equal(formatBytes(1001), '1.0 kB', '1001 bytes')
+  t.equal(formatBytes(1500), '1.5 kB', '1500 bytes')
+  
+  // Edge cases around rounding that currently fail
+  t.equal(formatBytes(999999), '1.0 MB', '999999 bytes -> 1.0 MB')
+  t.equal(formatBytes(1000000), '1.0 MB', '1000000 bytes -> 1.0 MB')
+  
+  t.equal(formatBytes(999999999), '1.0 GB', '999999999 bytes -> 1.0 GB')
+  t.equal(formatBytes(1000000000), '1.0 GB', '1000000000 bytes -> 1.0 GB')
+  
+  // Checking formatting without space
+  t.equal(formatBytes(999, false), '999B', '999B no space')
+  t.equal(formatBytes(1000, false), '1.0kB', '1.0kB no space')
+
+  t.end()
+})