fix required flag when destructuring an urlencoded object to parameters (#478)

Author: hauner

openapi-processor-core/src/main/kotlin/io/openapiprocessor/core/converter/ApiConverter.kt

@@ -423,7 +423,8 @@ class  ApiConverter(
         val parameters = mutableListOf<ModelParameter>()
         dataTypes.relRef(dataType.getName())
         dataType.forEach { property, propertyDataType ->
-            parameters.add(framework.createQueryParameter(UrlencodedParameter(property), propertyDataType))
+            parameters.add(framework.createQueryParameter(UrlencodedParameter(
+                property, dataType.constraints?.isRequired(property) == true), propertyDataType))
         }
         return parameters
     }

openapi-processor-core/src/main/kotlin/io/openapiprocessor/core/parser/UrlencodedParameter.kt

@@ -11,7 +11,7 @@ import io.openapiprocessor.core.openapi.Schema
 /**
  * "fake" parameter for framework-specific annotation selection
  */
-class UrlencodedParameter(val parameter: String): Parameter {
+class UrlencodedParameter(val parameter: String, private val required: Boolean = false): Parameter {
 
     override fun getIn(): String {
         return "urlencoded"
@@ -26,7 +26,7 @@ class UrlencodedParameter(val parameter: String): Parameter {
     }
 
     override fun isRequired(): Boolean {
-        return true
+        return required
     }
 
     override fun isDeprecated(): Boolean {

openapi-processor-core/src/test/kotlin/io/openapiprocessor/core/converter/ApiConverterRequestBodySpec.kt

@@ -302,6 +302,52 @@ class ApiConverterRequestBodySpec: StringSpec({
         bar.name shouldBe "bar"
     }
 
+    "converts request body application/x-www-form-urlencoded object schema properties to rrequired/not required request parameters" {
+        val options = parseOptions(options = """
+            |options:
+            |  bean-validations: true
+        """)
+
+        val openApi = parseApiBody("""
+            paths:
+              /foo:
+                post:
+                  requestBody:
+                    required: true
+                    content:
+                      application/x-www-form-urlencoded:
+                        schema:
+                          type: object
+                          required:
+                            - foo
+                          properties:
+                            foo:
+                              type: string
+                            bar:
+                              type: boolean
+                  responses:
+                    '204':
+                      description: empty
+            """)
+
+        val api = apiConverter(options).convert(openApi)
+
+        val itf = api.getInterfaces().first()
+        val ep = itf.endpoints.first()
+        val foo = ep.parameters[0]
+        val bar = ep.parameters[1]
+
+        foo.dataType.getName() shouldBe "string"
+        foo.dataType.getTypeName() shouldBe "String"
+        foo.required.shouldBeTrue()
+        foo.name shouldBe "foo"
+
+        bar.dataType.getName() shouldBe "boolean"
+        bar.dataType.getTypeName() shouldBe "Boolean"
+        bar.required.shouldBeFalse()
+        bar.name shouldBe "bar"
+    }
+
     "converts request body application/x-www-form-urlencoded object to request parameter" {
         val options = parseOptions(mapping =
             """