Commit cd64953
committed
Fix issue with EKS semver suffix
The semver suffix added by EKS indicated a "pre-release"
version, however the EKS team just wanted to add their own
custom tag, not to indicate a pre-release.
The check to print the correct ingress version can probably
be removed now since v1 became stable as of v1.19, that said
this change strips any K8s version suffix so that the
comparison does not fail.
It was failing because semverCompare considered any
pre-release version to be less than v1.19. Tested by
helm template.
We didn't see this issue before because most people
seem to create their own separate ingress records rather
than the one generated by the chart.
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>1 parent 6ed2e1d commit cd64953
File tree
14 files changed
+296
-271
lines changed- chart/openfaas
- templates
- docs
14 files changed
+296
-271
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
Binary file not shown.
Binary file not shown.
Large diffs are not rendered by default.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
0 commit comments