8369335: Two sun/java2d/OpenGL tests fail on Windows after JDK-8358058#4467
Open
rm-gh-8 wants to merge 1 commit into
Open
8369335: Two sun/java2d/OpenGL tests fail on Windows after JDK-8358058#4467rm-gh-8 wants to merge 1 commit into
rm-gh-8 wants to merge 1 commit into
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
Bot
changed the title
|
This backport pull request has now been updated with issue from the original commit. |
openjdk
Bot
added
backport
Contributor
Author
|
/approval request for backport of JDK-8369335: Two sun/java2d/OpenGL tests fail on Windows after JDK-8358058. This is a test fix. For parity with Oracle JDK. Already backported to 21. |
openjdk
Bot
added
approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8369335: Two sun/java2d/OpenGL tests fail on Windows after JDK-8358058.
This PR fixes two OpenGL tests (ScaleParamsOOB.java and OpaqueDest.java) fail after JDK-8358058 with color mismatch errors due to HiDPI fractional scaling issues when using OpenGL with hardware acceleration. Tests updated to handle Windows HiDPI fractional scaling correctly.
For parity with Oracle JDK. Already backported to 21.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/sun/java2d/OpenGL/OpaqueDest.java
make test TEST=test/jdk/sun/java2d/OpenGL/ScaleParamsOOB.java
Results:
Please note that similar to the backport for 21 and 25, "test/jdk/sun/java2d/OpenGL/ScaleParamsOOB.java" fails on linux-x64 and linux-aarch64. This will be addressed by #4471
windows-x64-specific-test.log
windows-x64-specific-2-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4467/head:pull/4467$ git checkout pull/4467Update a local copy of the PR:
$ git checkout pull/4467$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4467/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4467View PR using the GUI difftool:
$ git pr show -t 4467Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4467.diff
Using Webrev
Link to Webrev Comment