Move the logic of AbstractList::__toString() to Array_::__toString()

Author: mspirkov

src/Types/AbstractList.php

@@ -15,9 +15,6 @@
 
 use phpDocumentor\Reflection\Type;
 
-use function preg_match;
-use function substr;
-
 /**
  * Represents a list of values. This is an abstract class for Array_ and List_.
  *
@@ -48,6 +45,11 @@ public function __construct(?Type $valueType = null, ?Type $keyType = null)
         $this->keyType        = $keyType;
     }
 
+    /**
+     * Returns a rendered output of the Type as it would be used in a DocBlock.
+     */
+    abstract public function __toString(): string;
+
     public function getOriginalKeyType(): ?Type
     {
         return $this->keyType;
@@ -73,26 +75,4 @@ public function getValueType(): Type
     {
         return $this->valueType ?? $this->defaultValueType;
     }
-
-    /**
-     * Returns a rendered output of the Type as it would be used in a DocBlock.
-     */
-    public function __toString(): string
-    {
-        if ($this->valueType === null) {
-            return 'array';
-        }
-
-        $valueTypeString = (string) $this->valueType;
-
-        if ($this->keyType) {
-            return 'array<' . $this->keyType . ', ' . $valueTypeString . '>';
-        }
-
-        if (!preg_match('/[^\w\\\\]/', $valueTypeString) || substr($valueTypeString, -2, 2) === '[]') {
-            return $valueTypeString . '[]';
-        }
-
-        return 'array<' . $valueTypeString . '>';
-    }
 }

src/Types/Array_.php

@@ -13,6 +13,9 @@
 
 namespace phpDocumentor\Reflection\Types;
 
+use function preg_match;
+use function substr;
+
 /**
  * Represents an array type as described in the PSR-5, the PHPDoc Standard.
  *
@@ -26,4 +29,22 @@
  */
 class Array_ extends AbstractList
 {
+    public function __toString(): string
+    {
+        if ($this->valueType === null) {
+            return 'array';
+        }
+
+        $valueTypeString = (string) $this->valueType;
+
+        if ($this->keyType) {
+            return 'array<' . $this->keyType . ', ' . $valueTypeString . '>';
+        }
+
+        if (!preg_match('/[^\w\\\\]/', $valueTypeString) || substr($valueTypeString, -2, 2) === '[]') {
+            return $valueTypeString . '[]';
+        }
+
+        return 'array<' . $valueTypeString . '>';
+    }
 }

tests/unit/Types/ContextFactoryTest.php

@@ -262,5 +262,10 @@ public function assertNamespaceAliasesFrom(Context $context): void
     class Foo extends AbstractList
     {
         // dummy class
+
+        public function __toString(): string
+        {
+            return '';
+        }
     }
 }