About tags and markers

[RomainTT]

Hello,

Using pytest only, I am reading test markers thanks to the pytest hook pytest_collection_modifyitems:

def pytest_collection_modifyitems(session, config, items):
    for item in items:
        if "mymarker" not in item.own_markers:
            item.warn(PytestWarning("Missing marker 'mymarker'")

But it seems that @tags from feature files are not in own_markers 😞
According to my tests, own_markers is empty.

Am I missing something ?

My actual usecase is to combine pytest_bdd_apply_tag and pytest_collection_modifyitems:

def pytest_bdd_apply_tag(tag, function):
    if "mymarker" == tag:
        mark = getattr(pytest.mark, "mymarker")
        mark(function, "A custom argument")

def pytest_collection_modifyitems(session, config, items):
    for item in items:
        if "mymarker" not in item.own_markers:
            item.warn(PytestWarning("Missing marker 'mymarker'")
        # my custom argument should be here
        mymarker = item.get_closest_marker("mymarker")
        custom_arg = mymarker.args[0]

(this is a dummy example)

Thank you for your help!

[CasperKristiansson]

own_markers is a list of Mark objects, not marker names, so "mymarker" not in item.own_markers will report it missing even when the marker is there. get_closest_marker() is the right lookup.

Your custom hook also creates a decorator but never applies the argument-bearing marker. Make it run before pytest-bdd's default hook, decorate the function, and return True:

@pytest.hookimpl(tryfirst=True)
def pytest_bdd_apply_tag(tag, function):
    if tag == "mymarker":
        pytest.mark.mymarker("A custom argument")(function)
        return True

def pytest_collection_modifyitems(items):
    for item in items:
        marker = item.get_closest_marker("mymarker")
        if marker is None:
            continue  # emit your warning here
        custom_arg = marker.args[0]

I reproduced this on pytest-bdd 8.1.0: a normal feature tag appears in own_markers, and this hook preserves the custom argument.