Skip to content

pytest.RaisesGroup calls the check function with simple exceptions instead of the group #14324

Open

Description

@DavideCanton
  • a detailed description of the bug or problem you are having
  • output of pip list from the virtual environment you are using
  • pytest and operating system versions
  • minimal example if possible

The following code:

import pytest

def foo():
    raise ExceptionGroup("Main message", [ValueError("foo")])

def check(exc_group: ExceptionGroup) -> bool:
    print(exc_group.__class__)
    # example check
    return len(exc_group.exceptions) > 1

def test_foo():
    with pytest.RaisesGroup(ValueError, match="Main message", check=check):
        foo()

errors with AttributeError: 'ValueError' object has no attribute 'exceptions' because the check function gets invoked twice, the first time with the exception group for actually performing the check, and the second time with the ValueError raised by the foo function.

As a further proof, the stdout of the run is:

<class 'ExceptionGroup'>
<class 'ValueError'>

This seems wrong, as the docs of RaisesGroup says

check (Callable[[E], bool]) – If specified, a callable that will be called with the group as a parameter after successfully matching the expected exceptions. If it returns True it will be considered a match, if not it will be considered a failed match.

I'm on python 3.12, with just pytest==9.0.2 installed in the environment, but I can reproduce the same issue on 3.14.

Activity

  1. bluetech commented on May 3, 2026

    @bluetech
    Member

    This does seem like a bug.

    @jakkdl do you mind confirming that the intent is for check to only be called on the exception group, and not the exceptions?

  2. added theissue type on May 3, 2026
  3. jakkdl commented on May 11, 2026

    @jakkdl
    Member

    Ah, definitely an oversight. We only call check for the contained exception in order to be able to give a more helpful error message if it fails on the group - but I had not considered that it may crash if we try to do that. Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: bugproblem that needs to be addressed

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions